From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id B79AD3889811 for ; Tue, 13 Jul 2021 13:01:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B79AD3889811 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 16DD1S2m008945 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Jul 2021 09:01:33 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 16DD1S2m008945 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 52FC31E01B; Tue, 13 Jul 2021 09:01:28 -0400 (EDT) Subject: Re: [PATCH v4] [gdb] Add basic Z80 CPU support To: Sergey Belyashov Cc: gdb-patches@sourceware.org References: <5a120c4d-630a-08f5-fb81-d35237267adb@simark.ca> <20200925114042.14337-1-Sergey.Belyashov@gmail.com> From: Simon Marchi Message-ID: <5ad11b8d-bc58-6a6f-7781-2805f7376736@polymtl.ca> Date: Tue, 13 Jul 2021 09:01:27 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 13 Jul 2021 13:01:28 +0000 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 13:01:36 -0000 On 2021-07-13 1:42 a.m., Sergey Belyashov wrote: > You can safely remove these comments, but keep last one - it is reserved for GameBoy Z80 & Z80 Next CPUs. What's the intent for, this, is it there because it's going to be used / uncommented at some point? I'd like to add a comment to explain why it's commented out. Simon