From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't drop static function bp locations w/o debug info
Date: Sun, 13 Sep 2020 14:25:19 +0100 [thread overview]
Message-ID: <5aea0e8a-2d19-3fa0-5281-86e41be4b8b9@palves.net> (raw)
In-Reply-To: <22959b69-54bd-012e-4026-feb4f02ac671@simark.ca>
On 6/12/20 8:53 PM, Simon Marchi wrote:
> On 2020-06-12 3:21 p.m., Pedro Alves wrote:
>> @@ -4371,21 +4336,54 @@ search_minsyms_for_name (struct collect_info *info,
>>
>> if (!minsyms.empty ())
>
> You could remove this check and de-indent the rest. If minsyms is empty, the loop
> will just be skipped over.
>
> Otherwise, LGTM.
Thanks, I did that, and merged it now.
Pedro Alves
next prev parent reply other threads:[~2020-09-13 13:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 19:21 Pedro Alves
2020-06-12 19:53 ` Simon Marchi
2020-09-13 13:25 ` Pedro Alves [this message]
2020-09-22 20:20 ` Luis Machado
2020-09-24 15:16 ` Pedro Alves
2020-09-24 15:32 ` Luis Machado
2020-09-24 15:35 ` Pedro Alves
2020-09-24 15:44 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aea0e8a-2d19-3fa0-5281-86e41be4b8b9@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).