From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by sourceware.org (Postfix) with ESMTPS id 439D13857C56 for ; Sun, 13 Sep 2020 13:25:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 439D13857C56 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f66.google.com with SMTP id x14so15810580wrl.12 for ; Sun, 13 Sep 2020 06:25:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2yL3vvPv7W08dm6R1m7boExNuyQuWi3y/6/5jeAYTVg=; b=oXNKdsF7xf/+/5ilS4aY7MmuUgF3Uue4G6ixx49qPVfXmLTgeobzfaqXP9WtoWJKiE +c0ROswLDyK88VVYWQk5pfcAkjsWjg/XUWdYPSd0IFyWkofy67X03KxCdGg7RhugFEcT EW8JUVPiCBirGclBfpDt0RdRgueTZl6b3e1Bnxc0GLefw0JwJRR/UcnYLyeUFZNnx/iU zEPTwjZ9TbcgjcVCa+csWyxCNn5D7IvbuzkqFHWUXffBiZvxugg1BlDEs09YELoVOfTh cJ/B5r3a10HesVTMJxc8DTPBajlIEoDBP0sXok+Ma6pCKJldqf2L475XLxkXwDOPmO2m Fb3w== X-Gm-Message-State: AOAM530ipTo7CG2OzILP1GPm+PsnaK2f4jUq4jHq6f1nPr3F4S7GqyGE j1Z3CdFxrh4Gl5CSX1HicPUIEsbbqWPgiQ== X-Google-Smtp-Source: ABdhPJz0xbpSrbMXChojTVLLa8hJmnt8phMBnKlm2NtG5hW1lhZESzU4hL/VzE2bCyujiKG2ie0KOA== X-Received: by 2002:adf:ab46:: with SMTP id r6mr8058589wrc.360.1600003523635; Sun, 13 Sep 2020 06:25:23 -0700 (PDT) Received: from ?IPv6:2001:8a0:f905:5600:eefd:c63:53e0:3e8a? ([2001:8a0:f905:5600:eefd:c63:53e0:3e8a]) by smtp.gmail.com with ESMTPSA id o124sm14963669wmb.2.2020.09.13.06.25.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Sep 2020 06:25:22 -0700 (PDT) Subject: Re: [PATCH] Don't drop static function bp locations w/o debug info To: Simon Marchi , gdb-patches@sourceware.org References: <20200612192108.11481-1-pedro@palves.net> <22959b69-54bd-012e-4026-feb4f02ac671@simark.ca> From: Pedro Alves Message-ID: <5aea0e8a-2d19-3fa0-5281-86e41be4b8b9@palves.net> Date: Sun, 13 Sep 2020 14:25:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <22959b69-54bd-012e-4026-feb4f02ac671@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Sep 2020 13:25:27 -0000 On 6/12/20 8:53 PM, Simon Marchi wrote: > On 2020-06-12 3:21 p.m., Pedro Alves wrote: >> @@ -4371,21 +4336,54 @@ search_minsyms_for_name (struct collect_info *info, >> >> if (!minsyms.empty ()) > > You could remove this check and de-indent the rest. If minsyms is empty, the loop > will just be skipped over. > > Otherwise, LGTM. Thanks, I did that, and merged it now. Pedro Alves