From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1ECE3385840A for ; Thu, 23 Sep 2021 15:12:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1ECE3385840A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 18NFCLq9028661 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Sep 2021 11:12:26 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 18NFCLq9028661 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8B6631EE14; Thu, 23 Sep 2021 11:12:21 -0400 (EDT) Subject: Re: [PATCH][gdb/testsuite] Replace prepare_for_testing with build_executable To: Tom de Vries , gdb-patches@sourceware.org References: <20210917224909.GA15407@delia> From: Simon Marchi Message-ID: <5b995a81-afd0-adbb-1639-b1aecfa4d8e7@polymtl.ca> Date: Thu, 23 Sep 2021 11:12:21 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210917224909.GA15407@delia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 23 Sep 2021 15:12:21 +0000 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Sep 2021 15:12:29 -0000 On 2021-09-17 6:49 p.m., Tom de Vries via Gdb-patches wrote: > Hi, > > I noticed a pattern: > ... > if {[prepare_for_testing "failed to prepare" $testfile $srcfile $flags]} { > return -1 > } > > foreach var {a b} { > clean_restart ${binfile} > ... > } > ... > > In this case, gdb is restarted three times, while it's only necessary two > times. > > Fix this by replacing prepare_for_testing with build_executable. > > I wrote a script that attempts this tranformation on each test-case (only the > per-test part shown here): > ... > cd $build > make check RUNTESTFLAGS=$test > sum=$build/testsuite/gdb.sum > if ! grep -q "expected passes" $sum; then > echo skipping $test > return > fi > > grep ^# $sum > ref.txt > sed -i 's/prepare_for_testing/build_executable/' $src/$test > make check RUNTESTFLAGS=$test > > grep ^# $sum > mod.txt > if cmp ref.txt mod.txt; then > return > else > ( cd $src; git ch -f $test ) > fi > ... > > This patch is the result of running the script on all test-cases, minus the > cases where prepare_for_testing was used in a comment. Touches 76 test-cases. I didn't check all changes, but I agree with the idea of the patch. Simon