From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Ignore 0,0 entries in .debug_aranges
Date: Thu, 14 Apr 2022 18:04:13 +0100 [thread overview]
Message-ID: <5b9d8fbb-a13d-dc16-7191-503191b5722d@palves.net> (raw)
In-Reply-To: <20220414153916.3468409-1-tromey@adacore.com>
On 2022-04-14 16:39, Tom Tromey via Gdb-patches wrote:
> When running the internal AdaCore test suite against the new DWARF
> indexer, I found one regression on RISC-V. The test in question uses
> --gc-sections, and winds up with an entry in the middle of a
> .debug_aranges that has both address and length of 0. In this
> scenario, gdb assumes the entries are terminated and then proceeds to
> reject the section because it reads a subsequent entry as if it were a
> header.
>
> It seems to me that, because each header describes the size of each
> .debug_aranges CU, it's better to simply ignore 0,0 entries and simply
> read to the end. That is what this patch does.
>
> I've patched an existing test to provide a regression test for this.
Makes sense to me.
next prev parent reply other threads:[~2022-04-14 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 15:39 Tom Tromey
2022-04-14 17:04 ` Pedro Alves [this message]
2022-06-10 17:00 ` Jim Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b9d8fbb-a13d-dc16-7191-503191b5722d@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).