From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 1BC1A395B43C for ; Wed, 29 Apr 2020 15:27:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1BC1A395B43C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.193] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 78FF91F068; Wed, 29 Apr 2020 11:27:11 -0400 (EDT) Subject: Re: Patches for PR 25893 "gdbserver incorrectly handles program args containing space" To: Michael Weghorn , gdb-patches@sourceware.org References: <20200429111638.1327262-1-m.weghorn@posteo.de> From: Simon Marchi Message-ID: <5ba5d2af-1a96-a17e-baad-bba02f2b7145@simark.ca> Date: Wed, 29 Apr 2020 11:27:09 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200429111638.1327262-1-m.weghorn@posteo.de> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 15:27:13 -0000 On 2020-04-29 7:16 a.m., Michael Weghorn via Gdb-patches wrote: > Hi, > > I have taken a look why gdbserver currently cannot correctly handle > program args containing spaces (PR 25893, [1]) and am sending patches > that implement a potential solution for this in follow-up emails. > > This is the first time I'm trying to contribute to gdb and I haven't > completed an FSF copyright assignment so far. > I'm happy about any feedback on the patches, and also other hints in case > I've missed anything when reading the contribution guideline. > > If anybody has a better solution for the bug, please also go ahead and > I'll be happy to just drop my patches. > > Thanks in advance and best regards, > Michael > > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=25893 Hi Michael, Thanks for the patches. You've sent the patches using git-send-email, so that's already a very good start :). For your copyright assignment, if you haven't started the process already, take a look at this form. The instructions are included. http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future We'll try to review your patches soon, but given the volume of patches, there can be some delay. If you have no response after two weeks, please ping your patchset, and then weekly after that. That will keep it alive. Thanks, Simon