From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B148B3858D20 for ; Mon, 9 Jan 2023 10:12:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B148B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673259155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eoEA9RtgJQFzrnM1cShYr6moZMGhUpQocEdFGxgPtI4=; b=Te+hH//+vpD4y2/HtMHeDqbp3jcfF5qDBGKytqOIHZtGEA92cjPXoksdSCnq8MZgOT1c+b NlDf78X1eu7XgU2QuSS0pog/iaGS41K0ywe98n5PnPiBpFg0ladKKCu0gSHOB1z39J8UA2 TxM6XxGcPMME+bpmhzy2F6+pe34Qmu4= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-82-VqFu5k2pNsS5p8XstS5BSQ-1; Mon, 09 Jan 2023 05:12:34 -0500 X-MC-Unique: VqFu5k2pNsS5p8XstS5BSQ-1 Received: by mail-ej1-f69.google.com with SMTP id qw20-20020a1709066a1400b007c1727f7c55so5049613ejc.2 for ; Mon, 09 Jan 2023 02:12:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eoEA9RtgJQFzrnM1cShYr6moZMGhUpQocEdFGxgPtI4=; b=G2No6ebCTK/JN2tx21h9FFTpT5aAcOSxvAz0bft2dPcgt0qXWAPtNV3KxY4K86R5iJ XtAz5PKUDKkmK9LWkoPe9nWQZy+ojHLYl/SCuTtseZVx2Acwrj0bsUJvQbZ2g3maH6HJ 1EMjwFM4mx/loyU522EQ9D11/RtfM25BODAAppEixFB6D0rFmDfcS7SfpgG1M+IlwRsi U0isTFzh153mqzfM/NRvqCtUjcJFR/lilt9azNDBVCYe0a5BzsMIi2LrNyMbm1rtq1tz G8eWlusnIpplaYPbPjVMTPdWvV5M0DzTcloieKbXdmd+Q4NM8jgd4UWVFWeHFQ1AHO/j XJoQ== X-Gm-Message-State: AFqh2krSbSbYMk7hLvmzVvlo4OygjSaJqyHOW9goKzPhfY42hd9kuKlf p4ThMqDZJUcFRd12W4WZkoVUpNXp6bnGIGbExrTXW9h8gXVcf35962AUoGxyjdnXVIgpUtozKog Mn7gprleOA0avTZIclzARLQ== X-Received: by 2002:a17:906:78c:b0:7ad:e52c:12e6 with SMTP id l12-20020a170906078c00b007ade52c12e6mr55362013ejc.41.1673259152894; Mon, 09 Jan 2023 02:12:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXvf57arWcXy1F6WJO5BEBMf2K2vO1MTUYEeluEE+DDqxHs7Ad9eHV9KMCQbT4SJvjXUCRIdeQ== X-Received: by 2002:a17:906:78c:b0:7ad:e52c:12e6 with SMTP id l12-20020a170906078c00b007ade52c12e6mr55362008ejc.41.1673259152763; Mon, 09 Jan 2023 02:12:32 -0800 (PST) Received: from [192.168.0.45] (ip-62-245-66-121.bb.vodafone.cz. [62.245.66.121]) by smtp.gmail.com with ESMTPSA id g22-20020a170906539600b0080b3299ebddsm3570194ejo.13.2023.01.09.02.12.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 02:12:32 -0800 (PST) Message-ID: <5bb1b291-6726-0850-c525-175ae2cd2cb8@redhat.com> Date: Mon, 9 Jan 2023 11:12:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] Fix crash with C++ qualified names To: Tom Tromey , gdb-patches@sourceware.org References: <20221223195809.602699-1-tom@tromey.com> From: Bruno Larsen In-Reply-To: <20221223195809.602699-1-tom@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 23/12/2022 20:58, Tom Tromey wrote: > PR c++/29503 points out that something like "b->Base::member" will > crash when 'b' does not have pointer type. This seems to be a simple > oversight in eval_op_member. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29503 I can confirm that this fixes the issue, and seems like a simple enough change. Reviewed-By: Bruno Larsen -- Cheers, Bruno