From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id B88F43858D20 for ; Fri, 2 Dec 2022 19:38:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B88F43858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2B2JcX3t028141 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 2 Dec 2022 14:38:37 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2B2JcX3t028141 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1670009918; bh=H7F40i7L7zjsg0a+BssxdM37GtwgZRAChUC52fPSNhw=; h=Date:Subject:To:References:From:In-Reply-To:From; b=T0ZurEA41HXqO5YC1C4711xBlATBnZAbsxKtdd7vutQ4qZP9TgrF2A8hEt8GE66KQ MqklLPnY5yzJH9JjtT9fN2auENtu4fFOz9viBRbY104yK3saURliGs5+ElOeIBroTx 2xru5FR4+6lx70PZIm0kfgFycwrKEHDbQlp0dqLI= Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2B5E21E112; Fri, 2 Dec 2022 14:38:32 -0500 (EST) Message-ID: <5bc6dd53-0d4b-3679-72a0-d6a35847d3c5@polymtl.ca> Date: Fri, 2 Dec 2022 14:38:32 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/3] gdb: break up core_target initialization Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches References: <20221129025048.44490-1-simon.marchi@polymtl.ca> <20221129025048.44490-2-simon.marchi@polymtl.ca> <87v8mwmnrl.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87v8mwmnrl.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 2 Dec 2022 19:38:33 +0000 X-Spam-Status: No, score=-3038.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/30/22 11:05, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> diff --git a/gdb/inferior.h b/gdb/inferior.h > Simon> index 909e1819922d..a4a0304052e6 100644 > Simon> --- a/gdb/inferior.h > Simon> +++ b/gdb/inferior.h > Simon> @@ -50,6 +50,7 @@ struct thread_info; > > Simon> #include "progspace.h" > Simon> #include "registry.h" > Simon> +#include "observable.h" > > It seems strange for this hunk to be in this patch. > Is it needed at all? You are right, removed. Simon