From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2112.outbound.protection.outlook.com [40.107.116.112]) by sourceware.org (Postfix) with ESMTPS id 82D4A3858D20 for ; Tue, 20 Feb 2024 15:44:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 82D4A3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 82D4A3858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.116.112 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708443899; cv=pass; b=e4wFfYM69CHJfYskKcycYCQ4jBHETrqFFOd9uFm/xTl3OIlIMs3qleEmN5Q/8AHvmHbJM/o4HiLfZ/cQvPgIn5tZILhI9N0eDRwRLIV9jQ/OepwBJnrQ/SdY+LbKHqmAA74EWYU0A/zrxft6mrWtGoM3j8skrsRn0laePLQGy5o= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708443899; c=relaxed/simple; bh=xbbdmINznNSIumtNZY+f/4PwxykEhbirrmWBpFqXSZA=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=ej8Fy8qgBCopGGgiMUMiAjWhFAb8HLIhkMUP1OcdmwEuMTfetmpvNfyZIghHai6oWTomhqM4rofGSqR8ko+Gzvs/pWESa2lMpTeI7fGtH+3j0ydnrTqKmT+RJaDwlRAC9QwWpNSdREQ4UaSQoqJ8Rnsn87n8g+sBiMRY1YGK7Mw= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lSLbUuwwPVPrsJ7oFBKZ6hxJ4NCooOXi1FFxV9WQaElNGBe990lLc0tFFtSJ1A/+SvCqbMHkwzfg/l96pfx4hhSVTjTwhvQ9OFSozSm6F0UDQdTjZN9lKr7NKx82QWGwmhOg1qsqcAcbesGAT0Mab48PvsxR9ob1e6eyJ0PBZRbYGrWpF9cZ77E7JN2IkWgP+eMpAMebx48WyHlPMYmbVPmHpyz/QIaX59Ct0BUen4xiBQZsXjvxMHQQjQ4dWmU1t4m+HYz5m0v1r4BIFKrKElIkI379m7WaveikHr8uP+CoNMg5m53n4l32ICN6JT7WbeYCO7qzFsNGJiPBLc1qLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TCNaXUG+6pCSqn/jFbCH6r/BSGt1jq35Pv3zB/qc6gM=; b=GckNqRIVEn+WRXQiS0KdtmbftFHRZE6vUOKGwW0jhngXvRPhfom+qDbGZYchpGkbY/Dpj5LXK6Jt6nGF5IFsqpcZ8zSfQjFSJNOWV90Xeia+XIvCuMSUIxVY1TxcEmg3oJcJzvsPxsQjIfPZtaXcggEcFNHrrJzLe7yJxOxKTJ6rPhqD87/5W1BjPo9tHHLw9P/jP0RG1aEhQUrEeEsHaTcBLsvrrkPOG3TcDnYtLYvBKXQe6eYw9EdnVQlrNXvSYYE/SpprLVEqjtBlZ2lPbOwOYMxw+vSV8JINfSh6k0gvczSYsfAmzwEU7hf/LaUKMGz/0drFzxvdJr0guKCwqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TCNaXUG+6pCSqn/jFbCH6r/BSGt1jq35Pv3zB/qc6gM=; b=s05NpgWwpVHl9fJed8Je2jHNB4mH4rRxfhLG6qid2v+BMvtXf8wZ6LX+IGGgRFR197MzmAIJqkp+1858HoMKvSAWQu7KcnkdOvp86FpZCGCFeSIaPwEIB0yK5kiCYtutm1G9HNXLqfVzoa3gnVv9p/oEultRlW2Lu8GQENiaamXLkzKCZFhufosl+0rb8rVbADlzGLMSZE/UR3976LLcRaesmVL1XlwyhUJuiliCdwmE/NeWWCUpWF1wghVCLqOyBfbLhis0i2o0KnMOhY9Wh/edNN8wdksWnTfdeqRR0HZ5EdoNxL7HKBcpehTlC18QYWnCy65k4rgpB0ldv4g2PA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) by YT1PR01MB8908.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:cb::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.21; Tue, 20 Feb 2024 15:44:54 +0000 Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::c742:8ac6:fbc:c437]) by YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::c742:8ac6:fbc:c437%7]) with mapi id 15.20.7292.036; Tue, 20 Feb 2024 15:44:54 +0000 Message-ID: <5bdbc615-ad3c-46e0-ac4b-bc6b1ea0a556@efficios.com> Date: Tue, 20 Feb 2024 10:44:51 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: pass frames as `const frame_info_ptr &` To: Andrew Burgess , Simon Marchi , gdb-patches@sourceware.org References: <20240219180812.1943487-1-simon.marchi@polymtl.ca> <87frxn5qg4.fsf@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87frxn5qg4.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR08CA0015.namprd08.prod.outlook.com (2603:10b6:208:239::20) To YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5520:EE_|YT1PR01MB8908:EE_ X-MS-Office365-Filtering-Correlation-Id: ea67ef13-b0c2-4d7b-d703-08dc322ae196 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vZlTT8DjAkw6fJxUZfL/eOVmMjk+PQUwncnvwYPwDLuz/KJ7O05K0F6uiA1G9C+qLYpWj9SADQzZmchcPfEwMvIprB3CfLsLiNAKrZkEUKhGgfF3shoWS5mhekG1j9Goss+G6RDhDEgM6lpgYMOz37D2ACLEM5xdph7LZ0RTHxstRx/BMjw9jYVEpw9WEYITu1bci+LT/Z+0+hyGq1lgoK8rY3u0vOsWgDZwaWZeDk5PVhvazBmW6RbkDzjQzx5bq8IZ/wiFuqFmpAlBThaZ6UA+QaLMYBY4TfqlzhlhrBXRDT1lpf05bmYxiAh53zgL1dmgpZvZ3yn1L/g/QzcJGONuySjKNHON1eh3shoHjXTJqQkznYX5Rg5Jl9ap8mVGXgHInbSNiEzbESc1zj8HlpUuMW8oVwzZwWosP35A6CLrCyzWzLVCLvWqr+oariphUF8Kwxwh0UPHlXO/k7iCNHEsUf6tu+lIUme7kHoRG6tpUisUCJny4lgrBh7DqFficjfqPicH7EKR9JIQFGP6bhFCvAYNfOKGQYy7COWWuP4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGRjN2UxSlpzMTFJUi9SKzRoVk9ESGcrbDE1aHRzV0ExVmhndUdEcFlXYzdD?= =?utf-8?B?MWFDT1ArSlJ3Zi83c1Q3UkVHYXZIQXdOTkdqMUU1NFVjOFllYktHbGcyZE1C?= =?utf-8?B?T0VXNHZiSUZ1NmRpdnpsa1hXTXp4bkJ5ZGFXMFNDUEhvSVErbGVvMmxiM3o0?= =?utf-8?B?MjhGT2pFNDlCaFVEV1kxZlY4c0hUUUVxMTFaV3NFeXE4RFBMcGVKQTgrb1JT?= =?utf-8?B?dzM5VW0xcDA1THgydXFPL29FRVd1dkxZeG5FWWxGc3pWUjd0NmYvV2llNVlo?= =?utf-8?B?OVBwUlZNYXhiWUJOUnFVTkRJTUp2Nmp3ejI1QjVFOW10NTl6MzVFdEQzN29h?= =?utf-8?B?K0RMSGpVclpPTUtsUTN1eUY3YW5ZbjdKSXhwN2xxM2NhbVZOanRhRkVJbUFk?= =?utf-8?B?TytWOE9vTEkzaVJHaWFaV21DRTFvRW1ZTXp3VUZ1KzR3d1cvWUNnOE5zNUIy?= =?utf-8?B?ZzFFbC9mcEJjVGxpMGlCbTlDbWc2Yk9iQ29XY2U3TUovWlRpSkQ1ZmZyWEU1?= =?utf-8?B?NXpuOEpRSW9iWXMzS2V1aEFFTkI3K2ZBcnorUVZ5Ly9tVzFwMUprZW5YUGtz?= =?utf-8?B?NEdnMWtyVnRiZVIwNjh4aVZXSDdQM0hhSUdrd1N6UEgwQXNWeVF5T0NKeTE1?= =?utf-8?B?NEs3MVdBWUtTUmhhL1FjSXdCSFRUVDFZWTY3ZzhmbFRHZDROOVN0TnZBMS9s?= =?utf-8?B?cWFuVC9TVExHU0tTSjMwRkM3Ull6WkpuYjZLYitVSkZiRzdvWHdGZ01sOXdC?= =?utf-8?B?MHhZU0pVZmhmdys3ME1WNUttWHByY0puM1djMkhSUFhtM1JSbGVRWUZlcGdn?= =?utf-8?B?OGp1UkdPaXE4ZWRmbHRMRTc5UTRKaXRTOXpzdnpjbXhLSC9jR3RtRFNDSHpI?= =?utf-8?B?dzU2NTM0b3RPR3N5aXNpU2Z6bDYrSnp5bG1vblJnTlE5TitQcFk0djdnSVdJ?= =?utf-8?B?ajY4ZGxSbjFJQkFabWdvVkQvRlUySHVvN1pTVGlCeTZUUG5uSjJOdXpkZG9m?= =?utf-8?B?aXhMMDliNWhiRFYzVnBhRXdjTDhKejNVOXRGczlRemlpbUhLZGZPVU96TnNl?= =?utf-8?B?QjNGRGl2dEhZWXYrV1FDWHBRWTM5OXI0L1lSYitwMTN3RGZxeE9wZFlqUFQ4?= =?utf-8?B?UHRCQjdkNS9ESzY5d000aEFBdlh4LzVaMTZOUjgxM1lVdnlac01XbE1oc2lI?= =?utf-8?B?MGxQbmlYbEdxVC9BcW9ZaXkwcFhsYUVPbFcrT0V2Q0EwUGdaYnhhbmZCRGFs?= =?utf-8?B?MVllNGJtTXJEQU9PMk1mbDJlWEN0aC90YnhZbU5mS0pMNTk5OG1vVjUwd0hl?= =?utf-8?B?V2xvNEd1cVZCd0pDa2M1SUxZZTlHNnY1VlN0MFlZQ2JxV1p2cmhpcGkwSi9k?= =?utf-8?B?djR6TWRwRDdXc1dIYWFaTUkrUTk2TkNBRFZYUWdnZ3VrZ3BwQ2todFphRVp6?= =?utf-8?B?ZnQwV1pGOHVyL2RuREswVU5pUlhNeTd4RGlIdy9ieDNLaEpvVVpXVFhLUHdo?= =?utf-8?B?RmN0cndQZnhmdkNkemgwWnJmS1FHY1VBZjVJak9vSEY0NGtLQ3pJN3ZkL012?= =?utf-8?B?RC93ZkF3VlN5cWcyZGg3K3Zab3poaTBqV2NpTzRZbHJXblpBZzArcXpYY0ZI?= =?utf-8?B?Mml0Y3huY0pEcmIvaUxjUU5IcER1RGVCMmRPVlZRdm9SMmZ3QmpMdEFpWG1C?= =?utf-8?B?UW5Ra2FUNjYwb1BWcGxiOWhkcU1WRjJZeXFPQXZ4UHIyWHFWenZITlZ6aWU3?= =?utf-8?B?YU1QTy80dllFRFYwcmx6YW5mblpnRW9EWFZtcEovTi9qUkt1K1FtRjNtTmQ3?= =?utf-8?B?RGNGY0VnRGlSU1FUUlVYN3F6RmVYWk9US0dJeUZyaGpEakpIdzZQbFhXQlgw?= =?utf-8?B?bTY4TUZsOHprWVZTc2RlN0l3OGVOclFCWFlpY1VWWFFWRXc2eFQ4T0taa3gx?= =?utf-8?B?S002ZWRQVHdjNm5yZlhPZ0YxUnlNZC9yWDFaY1ZnYlA3NHRhbytUenRzeGJV?= =?utf-8?B?TFVQZ0dGWktzQlR4a01MMGV6dlJGMFZlNzhBMVYyWFVkenRuZFdqd1BERDBy?= =?utf-8?B?Q0Vra1A5QVpGaTBoL0ZudHFSdS9VWXN5SjIwMCtBeHVuT3JCbkt4ZStXd0w3?= =?utf-8?Q?vQNh85KzM52/XAEn3PYI05dFl?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea67ef13-b0c2-4d7b-d703-08dc322ae196 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2024 15:44:53.6052 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qCLHHNbDkpbdtCRMERo6Cs5AsHc/t2HJV0+b8qDk6umtJk4DFuoDPF/lgJaRnd1HM6PUcOLgJRCCPpLOp/8+Tw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB8908 X-Spam-Status: No, score=-3032.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/20/24 06:24, Andrew Burgess wrote: > > Thank you for this! > > I've wanted this change since frame_info_ptr was first added, but never > got around to actually writing the patch. > > I haven't looked through every line of this, but I did flick through, > and what I saw looks good. I also applied the patch and did a build > with no issues, except... To my defense, they were there previously! But I might as well remove them since I touch the lines. > > ... you've introduced trailing whitespace in 5 places! I've marked them > all in the patch below. When you reply in-line, can you trim the unrelevant portions of the patch? It's a bit difficult to find your replies in 12k lines. > > I'd be happy to see this merged. > > Approved-By: Andrew Burgess Thanks, will push with the spaces removed. Simon