From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id BE1153858D20 for ; Fri, 1 Sep 2023 15:14:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE1153858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 381FEkfA005826 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 1 Sep 2023 11:14:52 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 381FEkfA005826 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1693581292; bh=nOF8XJCvdgf6G2c3lY36KnnhWjICgxrt/5qPa8VT0+M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qSD2WsaUx+7KDjy106zgqZaOCFy3eo28IruDK9A1eQ14z/n4J4D2YbrDc3FVOy4fH RyMxHez/gGeDW50jr89Nids6UT/yK2+JZAS0covinoGXovPXrvlLmtowm/MMYA+nKE NY+vUQ9wsTxcd5SwV6jdJt1qJmVzm9ngnJfpcXxs= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8122E1E092; Fri, 1 Sep 2023 11:14:46 -0400 (EDT) Message-ID: <5be0e6eb-c786-4676-b620-2f1886c18c31@polymtl.ca> Date: Fri, 1 Sep 2023 11:14:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH^2] gdb: mips: Add MIPSR6 support Content-Language: fr To: "Maciej W. Rozycki" Cc: Dragan Mladjenovic , "gdb-patches@sourceware.org" , Chao-ying Fu References: <6dc411fa-5e25-44a1-81b4-9454aa424507@polymtl.ca> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 1 Sep 2023 15:14:47 +0000 X-Spam-Status: No, score=-3031.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/31/23 17:36, Maciej W. Rozycki wrote: > Hi Simon, > >> I can do a superficial review (formatting / coding style / general >> feeling), but can't speak about the behavior. Ideally Maciej would look >> at it, but if he's not available, I would be fine approving the patch, >> since it's isolated to the MIPS support. The code looks nice and >> well-organized. > > I can try, but I have been rather overloaded these days, and the change > is sufficiently large it probably requires a number of working days to > review in detail just for the initial iteration, as there's a lot to > cross-check here with documentation (there's always a second pair of > educated eyes required for this kind of a change). I agree, it's not something that can be properly reviewed with just a few minutes (even hours) to spare. > Mind that it's something I'd have to do entirely in my free time, and > also that I have no MIPSr6 hardware available, so that would include time > required to set up QEMU (assuming that it works without glitches) to do > any R6 verification (and this change still has to be verified not to break > existing MIPS targets). That's why I offer support primarily to other > enthusiasts running legacy MIPS hardware. That's completely understandable. That said, if somebody else that is trustworthy has a long term interest in the MIPS support in GDB (especially if it's a commercial interest), we could think about onboarding them as co-maintainers for the port. Simon