From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by sourceware.org (Postfix) with ESMTPS id 9A432382D508 for ; Tue, 7 Jun 2022 18:42:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A432382D508 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f45.google.com with SMTP id a15so16825482wrh.2 for ; Tue, 07 Jun 2022 11:42:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=f/cQlGPd17E1r2xg4ahxzQ56229t1U9w+VhkpbSc3M4=; b=aD2M3O26HUWl1kuD0faAbrSl08YJG9gaxskW25j9hPRosvfVAINkbL76lfUWS7Sg7s q9C+ppbYgPognbK3/hhIXM24Uuf0ZhebVKl8nIpRCB6OafzxUMOhJG+nB0idjd/TihHK QanrEU2AIhRkSooUeN5PXQQAkuLsJhK1AGZmSzoc1ykEmJ/AU1tYNnuWml4JQBI+vfBX zv4Y2vTxA/ffk3/asrt3QiWfgoOZaoxzWqcW26AVieyMkWfoOpJtbcIdkyTJ6tYOM/9m UCxb0UFjx61GPIvxCd7E6go5UZStw/rXkMv3L4nGYXcCgvBDp2LHluuJEEMuBWnok3dV Ktkg== X-Gm-Message-State: AOAM531+hqIYJMR/okoLhacmfBfLobd5RbWgiqjn/XK6FolxAJWB54iv ed0WBLF5JhDJJqIa8RRSj73w/uzvCic= X-Google-Smtp-Source: ABdhPJwWw1wRQdnLirRMUhCLfsdIPuuzGsv4IK5Ei6wNa9ifn9KYwiuvS91/QtY8+N5+hUsypSHt8Q== X-Received: by 2002:a5d:64aa:0:b0:218:4287:3c98 with SMTP id m10-20020a5d64aa000000b0021842873c98mr10693472wrp.453.1654627377299; Tue, 07 Jun 2022 11:42:57 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id m125-20020a1ca383000000b0039c5b4ab1b0sm2052619wme.48.2022.06.07.11.42.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 11:42:56 -0700 (PDT) Message-ID: <5c316bab-c2d3-309e-f938-7480e861b444@palves.net> Date: Tue, 7 Jun 2022 19:42:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 5/5] gdb: native target invalid architecture detection Content-Language: en-US To: Luis Machado , Andrew Burgess , John Baldwin , gdb-patches@sourceware.org References: <71a986a5-2cfa-543e-4034-70f3af7dfecf@FreeBSD.org> <87ee09d4rt.fsf@redhat.com> <09afe250-9573-45e1-993b-a2f911f03630@arm.com> <87ilpdhn73.fsf@redhat.com> <87ee01hed4.fsf@redhat.com> <12c3913e-186d-b676-fe52-cc3322b00926@arm.com> From: Pedro Alves In-Reply-To: <12c3913e-186d-b676-fe52-cc3322b00926@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 18:43:00 -0000 On 2022-06-07 12:03, Luis Machado via Gdb-patches wrote: > Yeah, sorry for the poor experience. I can confirm your procedure is > correct, and that you built GDB correctly. Unfortunately this part of > the AArch64 port seems to have rotted away given it is a less common > execution scenario. This is actually covered by the testsuite, since: ~~~~~ commit 71be1fdc3655a170f4b14d795e5c9e81fcea06ef Author: Yao Qi AuthorDate: Tue Jul 7 16:58:19 2015 +0100 Commit: Yao Qi CommitDate: Tue Jul 7 16:58:19 2015 +0100 Adjust gdb.multi tests for aarch64 Multi-arch related tests under gdb.multi are to compile programs with the same compiler but different compiler options (-m64 vs -m32). However, different compilers are needed to compile both aarch64 program and arm (aarch32) program. This patch is to adjust these test cases to compile programs in different modes with different compiler. When we use gcc for arm-linux target, its file name can be different, arm-linux-gnueabihf-gcc, arm-linux-gnueabi-gcc, or arm-none-linux-gnueabi-gcc, so I add a variable ARM_CC_FOR_TARGET, so that user can set the name of gcc for arm-linux target on aarch64, like: $ make check RUNTESTFLAGS='ARM_CC_FOR_TARGET=arm-linux-gnueabihf-gcc multi-arch.exp' gdb/testsuite: 2015-07-07 Yao Qi * gdb.multi/multi-arch-exec.exp: Set march1 and march2 to "" if target is aarch64. If target is aarch64, set compiler=${ARM_CC_FOR_TARGET} if it exists. * gdb.multi/multi-arch.exp: Likewise. ~~~~~ I guess the issue is that nobody ever remembers to set ARM_CC_FOR_TARGET, or even knows about it. IWBN if the aarch64 bots people have access to tested with ARM_CC_FOR_TARGET, if they aren't already. Maybe it would be possible to come up with a way to default ARM_CC_FOR_TARGET to something that works for most people when testing aarch64, somehow.