From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 11E0539B9C17 for ; Thu, 19 Aug 2021 18:43:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 11E0539B9C17 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 17JIhWOG011304 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Aug 2021 14:43:36 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 17JIhWOG011304 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 031C21E79C; Thu, 19 Aug 2021 14:43:32 -0400 (EDT) Subject: Re: [PATCH 3/6] gdb: Add a dependency between gdb and libbacktrace To: Andrew Burgess , gdb-patches@sourceware.org References: <0b8ebcf5d8b4867a9612420cb8546797b5407647.1629366146.git.andrew.burgess@embecosm.com> From: Simon Marchi Message-ID: <5c793f9a-bf20-8bdf-7952-80e0fe46d7fe@polymtl.ca> Date: Thu, 19 Aug 2021 14:43:31 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <0b8ebcf5d8b4867a9612420cb8546797b5407647.1629366146.git.andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 19 Aug 2021 18:43:32 +0000 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2021 18:43:48 -0000 On 2021-08-19 5:49 a.m., Andrew Burgess wrote: > GDB is going to start using libbacktrace, so add a build dependency. > > ChangeLog: > > * Makefile.def: Add all-gdb dependency on all-libbacktrace. > * Makefile.in: Regenerate. > --- > Makefile.def | 1 + > Makefile.in | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Makefile.def b/Makefile.def > index 5a460f1dbbc..d5b1ee882b6 100644 > --- a/Makefile.def > +++ b/Makefile.def > @@ -408,6 +408,7 @@ dependencies = { module=all-gdb; on=all-sim; }; > dependencies = { module=all-gdb; on=all-libdecnumber; }; > dependencies = { module=all-gdb; on=all-libtermcap; }; > dependencies = { module=all-gdb; on=all-libctf; }; > +dependencies = { module=all-gdb; on=all-libbacktrace; }; > > // Host modules specific to gdbserver. > dependencies = { module=configure-gdbserver; on=all-gnulib; }; > diff --git a/Makefile.in b/Makefile.in > index 9b3a5d75735..91b714f6e88 100644 > --- a/Makefile.in > +++ b/Makefile.in > @@ -52534,6 +52534,7 @@ all-gdb: maybe-all-libiconv > all-gdb: maybe-all-opcodes > all-gdb: maybe-all-libdecnumber > all-gdb: maybe-all-libctf > +all-gdb: maybe-all-libbacktrace > all-gdbserver: maybe-all-libiberty > configure-gdbsupport: maybe-configure-intl > all-gdbsupport: maybe-all-intl > I was surprised that this worked, even though libbacktrace isn't imported yet. LGTM, but would this need to be sent to binutils as well (maybe just a FYI, a formality)? Simon