From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0E57B385EC09 for ; Mon, 6 May 2024 14:51:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E57B385EC09 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0E57B385EC09 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715007065; cv=none; b=p7pZvbOtw3AxE4/RQ+w3mRjTKdKno0jGqhmVLGoWCZF+pVC1OvSvpdKxF6ojV4wpNFS1YtICVMiSbEIlqXuOMPvHnADffREK7oW0RK+ZYcAb/skM6WCJnertY87u9qS9G7yeTglyNtDpesgwbBDu2Ht9WuWmD2WSKil4jgX+YM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715007065; c=relaxed/simple; bh=/vspJOMYARClulPaozgp15d9rybCW00g+aWx1PhDSOg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=RHFxJPVpeDSGYzFL9x+ChCLkMNzF54kR/GSw5iteyR67J+VJkbXeuG8ZzI7+nrK8QRKLnYd3glS4xd5LfiKjNsCO05aWtuJm+x5lJmwd80BOUCVk7ZhP7MJLqx40NrOOGB7uNl/2uA2DBLFH3hTcKYm3JXoEMmdFen3HSs1BjEk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715007062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/9rHDHGL6uYq8NxKKpIW1Kv6PxBgZoMRY3gYjfazKws=; b=GtpH4AgEi46jK++m+NIUE7dDJ3liy658qCNA7h2IrDC1RAJOTZmbPYgg7W5/6XU1T5+572 J1RjpnQq8NP4tF3xpPtjMQlViP6Q34vhW4K52rQ0Lv2zKwE65p3KvPaX+Z+Ie3vdUjbc6K t/rZPrXMyQZuKx5cVU2St45Ph4jEcRE= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-wYYe0284NHqCRluoVgivxQ-1; Mon, 06 May 2024 10:51:00 -0400 X-MC-Unique: wYYe0284NHqCRluoVgivxQ-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7928e0650b1so320983385a.1 for ; Mon, 06 May 2024 07:51:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715007060; x=1715611860; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/9rHDHGL6uYq8NxKKpIW1Kv6PxBgZoMRY3gYjfazKws=; b=EHaEKYGVWKNYT9yMlkflgFFTpIxBb2UOSOHA/w0qiHFS5PP+Elfi00dYokfM0yXbr0 plygzl32JNcdIePTU0Mqg23Fx0yhUO7nBI0bQF2zGEDiXVLR6IpdFTIqnB85a66WRbjH NUb8jdT0wy024uXmtfBp8V2K8ldrnvIqopWXK6k53y50JnmdprZL2EdrbJ4bZQT9JCjq U5VbdoqoPeq8RXMF0p66ulV6ppx0gf/wvfVmQlZearksoRRIJv8/1afq/D6mYhdkpYhA 7/V8Odw/VNJvRZMjIibYjnvr5jUZ92tessrQD7Ezym6f/2o/cc3XpTc0w24Z9H619h0v Eo5w== X-Forwarded-Encrypted: i=1; AJvYcCWK4J2SSAR7lbZsV+61pblitsgjdHD32VMQSq1gRpoQtZwgYt0lSi4I6+Gc7a8rk4O8irXW+0wdxLgKVc4DpbZAnx2sX3gVUMz6Ew== X-Gm-Message-State: AOJu0YzJXAhaRtk8VloCbkntmx+ExEQ3ccWcFLpFY5wZrHGAScRMLDE1 5560tw4ktsRzJXwgoAwzeti61GmSgGg77WI5IPCynpdKMEbrhlL92ENIvAKsPxc2xNXT8UJaK+g 2JY/Z+IpuFniph6k7dwEkvhfBv/rfmg15gSHOD2xo68SPlXrFswYvU3brFoI= X-Received: by 2002:a05:620a:5373:b0:790:f6ba:4976 with SMTP id op51-20020a05620a537300b00790f6ba4976mr9955911qkn.71.1715007058392; Mon, 06 May 2024 07:50:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGVau/EbL7GRl1sc0gQygtcwfqnV6pNK9lWrFHtrJN1YUpFaihyAuZhGH+65cAcfaRlaAfVyg== X-Received: by 2002:a05:620a:5373:b0:790:f6ba:4976 with SMTP id op51-20020a05620a537300b00790f6ba4976mr9955890qkn.71.1715007057761; Mon, 06 May 2024 07:50:57 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1000? ([2804:14d:8084:92c5::1000]) by smtp.gmail.com with ESMTPSA id m26-20020ae9e01a000000b007928f7a8dc7sm1981033qkk.53.2024.05.06.07.50.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 May 2024 07:50:57 -0700 (PDT) Message-ID: <5c867d2e-439b-443d-ace1-5e2caf5100b2@redhat.com> Date: Mon, 6 May 2024 11:50:54 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] Change message when reaching end of reverse history. To: "Metzger, Markus T" , Alex Chronopoulos , "gdb-patches@sourceware.org" Cc: Pedro Alves References: <20240414193653.3289837-1-achronop@gmail.com> <72c908ba-26c4-48c1-bedb-b75aad0c3733@palves.net> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------OgLoGz4B0FSsX9QVQtM2r0FQ" Content-Language: en-US X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------OgLoGz4B0FSsX9QVQtM2r0FQ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/6/24 02:19, Metzger, Markus T wrote: > > I’d prefer compact, one-line (error) messages.  A longer explanation > can go into the manual or in the help text.  E.g. > >     Stopping replaying at end of execution history > This simple message brings us all the way back around to the original problem. It's not obvious to a new user that they can keep going and things will continue to be recorded. If you really want something very short, a "check 'help record'" hint and some text explaining that forward execution can always be resumed (if using record full or record btrace), and if you're executing further new forward execution is added to history, that's ok too. I don't think the manual is enough, if nothing else, because new users are unlikely to find and read the manual in my experience. -- Cheers, Guinevere Larsen She/Her/Hers > and > >     Stopping at beginning of execution history > > Markus. > > *From:* Alex Chronopoulos > *Sent:* Friday, May 3, 2024 7:17 PM > *To:* gdb-patches@sourceware.org > *Cc:* Pedro Alves ; Metzger, Markus T > ; Guinevere Larsen > *Subject:* Re: [PATCH v3] Change message when reaching end of reverse > history. > > Thank you, Pedro. No worries, it's still early enough :) > > I like your suggestions and would happily follow them. I believe they > are clear and leave fewer questions for the user. > > I also prefer the extended version for the backward case. However, I > don't want to make the final call. I'll wait for others to comment, > and I'll update the patch when we have the final version. > > On Tue, Apr 23, 2024 at 10:36 PM Pedro Alves wrote: > > Sorry for not chiming in earlier... > > On 2024-04-14 20:36, Alex Chronopoulos wrote: > > In a record session, when we move backward, GDB switches from normal > > execution to simulation. Moving forward again, the emulation > continues > > until the end of the reverse history. When the end is reached, the > > execution stops, and a warning message is shown. This message > has been > > modified to indicate that the forward emulation has reached the > end, but > > the execution can continue as normal, and the recording will > also continue. > > > > Before this patch, the warning message shown in that case was > the same as > > in the reverse case. This meant that when the end of history was > reached in > > either backward or forward emulation, the same message was > displayed: > > > > "No more reverse-execution history." > > > > This message remains for backward emulation. However, in forward > emulation, > > it has been modified to: > > > > "End of recorded history; following steps will be added to history." > > > > IMO, "steps" here is confusing.  It's ambiguous with stepping.  > Like as if > you're saying that the following "step" commands will be added to > history. > "But what about if I continue??" > > It also isn't true that "following steps will be added to > history.".  If > the user does "reverse-continue" for example, they won't, they're > already there... > > The following tweak would be more accurate and not have that > "step" confusion, IMO: > >  "End of recorded history; following forward execution will be > added to history." > > and it's still under 80 chars. > > Except it fells a bit awkward, for not stating that we're stopping > before > talking about following execution.  This would be clearer to me: > >   Reached end of recorded history; stopping. >   Following forward execution will be added to history. > > > Also, with the patch, we have these two messages, for the forward > case: > >  End of recorded history; following steps will be added to history. > > and for the reverse case: > >  No more reverse-execution history. > > I read the v1/v2 discussions, and I have to say that I don't > understand how > the potential user confusion that led to changing the "No more > reverse-execution" > wording in the forward case doesn't apply to the reverse case...  > I think > we should be consistent. > > With my suggestion above, we could have: > > forward: > >   Reached end of recorded history; stopping. >   Following forward execution will be added to history. > > backward: > >   Reached end of recorded history; stopping. > > or, backward: > >   Reached end of recorded history; stopping. >   Backward execution from here not possible. > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 > --------------OgLoGz4B0FSsX9QVQtM2r0FQ--