From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 2757D385829F for ; Mon, 10 Oct 2022 19:41:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2757D385829F Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29AJBnBi025227 for ; Mon, 10 Oct 2022 19:41:38 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3k3k0tsuru-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 10 Oct 2022 19:41:38 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 29AJa2DS013272 for ; Mon, 10 Oct 2022 19:41:37 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma03dal.us.ibm.com with ESMTP id 3k30uahvm0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 10 Oct 2022 19:41:37 +0000 Received: from smtpav04.wdc07v.mail.ibm.com ([9.208.128.116]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 29AJfZ2S53674324 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Oct 2022 19:41:36 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 850D858045; Mon, 10 Oct 2022 19:41:35 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A8BC458054; Mon, 10 Oct 2022 19:41:34 +0000 (GMT) Received: from sig-9-65-248-8.ibm.com (unknown [9.65.248.8]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 10 Oct 2022 19:41:34 +0000 (GMT) Message-ID: <5c8dbf7b7a99d71ddac4b64a0553db2f250ed1ed.camel@us.ibm.com> Subject: [PATCH] PowerPC, fix test gdb.base/watchpoint-stops-at-right-insn.exp From: Carl Love To: "gdb-patches@sourceware.org" Cc: Ulrich Weigand , Will Schmidt , cel@us.ibm.com Date: Mon, 10 Oct 2022 12:41:33 -0700 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: LduyEL4WGiDnmsXPZc57HpdrKQTspv3x X-Proofpoint-ORIG-GUID: LduyEL4WGiDnmsXPZc57HpdrKQTspv3x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-10-10_12,2022-10-10_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 mlxlogscore=698 suspectscore=0 mlxscore=0 adultscore=0 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210100115 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2022 19:41:56 -0000 GDB maintainers: The following patch disables the gdb.base/watchpoint-stops-at-right- insn.exp test on Power 9. The Power 9 processor does not support hardware breakpoints due to a HW bug. The test should be skipped on Power 9. The following patch updates the test for hardware watchpoint support to use the correct test skip_hw_watchpoint_tests on PowerPC to determine if the PowerPC processor supports hardware watchpoints. The patch has been tested on X86-64, Power 9 and Power 10 with no regressions. Please let me know if the patch is acceptable. Thanks. Carl Love ---------------------------------------- PowerPC, fix test gdb.base/watchpoint-stops-at-right-insn.exp Test gdb.base/watchpoint-stops-at-right-insn.exp generates 4 test errors on Power 9. The test uses the test [target_info exists gdb, no_hardware_watchpoints] to determine if the processor supports hardware watchpoints. The check only examines the processor type to determine if it supports hardware watchpoints. Note, the test works fine on Power 10. The PowerPC processors support hardware watchpoints with the exception of Power 9. The hardware watchpoint support was disabled on Power 9 due to a hardware bug. The test skip_hw_watchpoint_tests must be used to correctly determine if the PowerPC processor supports hardware watchpoints. This patch replaces the [target_info exists gdb,no_hardware_watchpoints] with the skip_hw_watchpoint_tests_p check. With the patch, the test is disabled on Power 9 but runs on all other PowerPC processors. The patch has been tested on Power 9, Power 10 and X86-64 with no regression failures. --- gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp b/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp index f9adb1f4f91..6c445d4cbd8 100644 --- a/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp +++ b/gdb/testsuite/gdb.base/watchpoint-stops-at-right-insn.exp @@ -71,7 +71,7 @@ standard_testfile # No use testing this if we can't use hardware watchpoints. -if {[target_info exists gdb,no_hardware_watchpoints]} { +if {[skip_hw_watchpoint_tests]} { return -1 } -- 2.37.2