Re: [PATCH] Make GDBserver abort on internal error in development mode

[Simon Marchi <simark@simark.ca>]

On 2022-06-24 09:26, Pedro Alves wrote:
> Currently, if GDBserver hits some internal assertion, it exits with
> error status, instead of aborting.  This makes it harder to debug
> GDBserver, as you can't just debug a core file if GDBserver fails an
> assertion.  I've had to hack the code to make GDBserver abort to debug
> something several times before.
> 
> I believe the reason it exits instead of aborting, is to prevent
> potentially littering the filesystem of smaller embedded targets with
> core files.  I think I recall Daniel Jacobowitz once saying that many
> years ago, but I can't be sure.  Anyhow, that seems reasonable to me.

Thanks for mentioning this, I was going to ask "why don't we just abort
all the time".  On non-embedded targets it could be useful to abort,
since it triggers the various distros error reporting tool (like ABRT on
Red Hat), and make reporting crashes easier.  But the embedded target
case also makes sense.  Your patch LGTM, it's a good change on its own.
If someone wants to add a --make-gdbserver-abort-on-internal-error
configure switch later (and convince distros to use it), I'd be ok with
that.

Simon