From: Simon Marchi <simark@simark.ca>
To: gdb-patches@sourceware.org,
Thomas Schwinge <thomas@codesourcery.com>,
thomas@schwinge.name, bug-hurd@gnu.org
Subject: Re: [PATCH 1/5] hurd: fix gnu_debug_flag type
Date: Fri, 29 May 2020 16:44:46 -0400 [thread overview]
Message-ID: <5c9e3fd1-eb2d-07d8-e72e-1671a62751ed@simark.ca> (raw)
In-Reply-To: <20200529200109.2qzmgxwtnm7fzfzs@function>
On 2020-05-29 4:01 p.m., Samuel Thibault wrote:
> gdb/ChangeLog:
>
> 2020-05-29 Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> * gdb/gnu-nat.h (gnu_debug_flag): Set type to bool.
>
> diff --git a/gdb/gnu-nat.h b/gdb/gnu-nat.h
> index 77c57817b2..7c36778394 100644
> --- a/gdb/gnu-nat.h
> +++ b/gdb/gnu-nat.h
> @@ -111,7 +111,7 @@ extern char *proc_string (struct proc *proc);
> __proc_pid (__proc), __proc->tid, \
> host_address_to_string (__proc) , ##args); } while (0)
>
> -extern int gnu_debug_flag;
> +extern bool gnu_debug_flag;
>
> #define debug(msg, args...) \
> do { if (gnu_debug_flag) \
>
Please mention in each patch's message what is the problem you are trying to fix.
Simon
prev parent reply other threads:[~2020-05-29 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 20:01 Samuel Thibault
2020-05-29 20:02 ` [PATCH 2/5] hurd: add missing awk script dependency Samuel Thibault
2020-05-29 20:04 ` [PATCH 3/5] hurd: make function cast stronger Samuel Thibault
2020-05-29 20:07 ` [PATCH 4/5] hurd: add gnu_target pointer to fix thread API calls Samuel Thibault
2020-05-29 20:09 ` [PATCH 5/5] hurd: remove unused variables Samuel Thibault
2020-05-29 20:44 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c9e3fd1-eb2d-07d8-e72e-1671a62751ed@simark.ca \
--to=simark@simark.ca \
--cc=bug-hurd@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=thomas@codesourcery.com \
--cc=thomas@schwinge.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).