From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 783FA3850430 for ; Mon, 20 Mar 2023 17:45:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 783FA3850430 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 08DD61E110; Mon, 20 Mar 2023 13:45:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1679334352; bh=JNPbyFK1h5Bz64GuoKfJrkmPCiF67H1gA0BoLSSNcAg=; h=Date:Subject:To:References:From:In-Reply-To:From; b=agvwj1N/v/nZoVeNuXSdO4Wq/BPgCCzOseVTO+X7yPbyr4kCAbahB+NC9GE54SAan NQ4e+VPwhKs5qrI3HZqFczCvk1/okBGQILWie9fyg27SHXKsGidmslp9lLIZzWQD5a nFeLA9iAa3h9RsHMskNePFJs3Ktrp4npN4amuwc4= Message-ID: <5cb5ef09-dd04-8160-29bb-bda527d88e27@simark.ca> Date: Mon, 20 Mar 2023 13:45:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 2/9] fbsd-nat: Avoid a direct write to target_waitstatus::kind. Content-Language: fr To: John Baldwin , gdb-patches@sourceware.org References: <20230228181845.99936-1-jhb@FreeBSD.org> <20230228181845.99936-3-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: <20230228181845.99936-3-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/28/23 13:18, John Baldwin wrote: > This is in #ifdef'd code for a workaround for FreeBSD versions older > than 11.1 which is why it wasn't caught earlier. > --- > gdb/fbsd-nat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c > index 4e48bfa1590..2f5b512fb33 100644 > --- a/gdb/fbsd-nat.c > +++ b/gdb/fbsd-nat.c > @@ -1261,7 +1261,7 @@ fbsd_nat_target::wait_1 (ptid_t ptid, struct target_waitstatus *ourstatus, > wptid = fbsd_next_vfork_done (); > if (wptid != null_ptid) > { > - ourstatus->kind = TARGET_WAITKIND_VFORK_DONE; > + ourstatus->set_vfork_done (); > return wptid; > } > #endif > -- > 2.38.1 > Approved-By: Simon Marchi I think this could also be considered obvious, and you are the maintainer of this fail anyway, so it's fine to just push fixes that are likely not controversial. Simon