From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20046.outbound.protection.outlook.com [40.107.2.46]) by sourceware.org (Postfix) with ESMTPS id BE0DE3858415 for ; Wed, 9 Mar 2022 14:24:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BE0DE3858415 Received: from AM7PR04CA0029.eurprd04.prod.outlook.com (2603:10a6:20b:110::39) by DU2PR08MB7343.eurprd08.prod.outlook.com (2603:10a6:10:2f2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.26; Wed, 9 Mar 2022 14:24:28 +0000 Received: from AM5EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:110:cafe::3f) by AM7PR04CA0029.outlook.office365.com (2603:10a6:20b:110::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14 via Frontend Transport; Wed, 9 Mar 2022 14:24:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT038.mail.protection.outlook.com (10.152.17.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Wed, 9 Mar 2022 14:24:28 +0000 Received: ("Tessian outbound 63bb5eb69ee8:v113"); Wed, 09 Mar 2022 14:24:28 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: cbf1561259654331 X-CR-MTA-TID: 64aa7808 Received: from 566472f9d116.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D830230C-B629-4F58-B638-A55BCE5FC6FF.1; Wed, 09 Mar 2022 14:24:21 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 566472f9d116.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Mar 2022 14:24:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YdhRKPHXyBGtRD1snt0/JdB4qJpeRhCHEYbZg31u0PUv5o2P4MNr6foDBZ3QBrTW6efA9DIhdM20xIeEppOkLbalx4TljFvzdSrRbzuBpC+zrB9UDSTuI+xh6wuLwWF7H6Bg4WWdXUN9T0/7qJIY2MyfjWOvB5QwX/h/aitMZa+zqx2J1+zsoymfHisiduQqZuYF/ZOFz7LmfJpTlQiZaJxNyLMUSHe9JlMj5nLutTVGhuTsyrHPK2+9L2m5j658cV0CLR6tZ/6lyNrECk4St6DQJ43sDr0Oqpk4Rjj6pB1o6/lxrpPqpQo8N+R8hbYSXHfZ2sIxGa7kvivSZeH9uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZpOQqNv51e56QXSJLSHuPz5BkGtq18zQhaiD+jlu6WA=; b=oHdu8xsWYSiKAxpqi2DHT3CxLGM7X/cdSOv4ccYWdp+sToQjQ4ZETlzgr2FOwyplJz7C9qXfl1tEpwBDafOv0BaLHg3A2flR8tQomESVfc9DmBCjmE8OdLKH07i4jAcyCPocDbYWIpYHuF6klO3fjmEcKDV5aFilRkthx/O7/Yc4x18BuT5yx4mhBrkSx+HNCl9jkp9SstDZbA5Dfhwc9T7Uh9/ZGycocr7xWIRrP3a+bXY3AXNwt+BdoaWLFrYYRWiXHUjCo6Qzmd87Adt2BOYWlOnTzm7erm8jsU/6j5uj2LDSC5OLWN8b8lTWRNYMlae7dZDUDGdZJ0s/mofs+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM0PR08MB5315.eurprd08.prod.outlook.com (2603:10a6:208:18e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Wed, 9 Mar 2022 14:24:19 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::457d:362e:8883:dd2a]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::457d:362e:8883:dd2a%7]) with mapi id 15.20.5038.027; Wed, 9 Mar 2022 14:24:19 +0000 Message-ID: <5cd04873-8e2f-0b93-076a-980bf069fe7f@arm.com> Date: Wed, 9 Mar 2022 14:24:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 1/2] gdb: rename floatformats_ia64_quad to floatformats_ieee_quad Content-Language: en-US To: Tiezhu Yang , gdb-patches@sourceware.org References: <1646740859-28698-1-git-send-email-yangtiezhu@loongson.cn> <1646740859-28698-2-git-send-email-yangtiezhu@loongson.cn> From: Luis Machado In-Reply-To: <1646740859-28698-2-git-send-email-yangtiezhu@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0102.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::17) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 62622c35-11a8-4950-2844-08da01d8854d X-MS-TrafficTypeDiagnostic: AM0PR08MB5315:EE_|AM5EUR03FT038:EE_|DU2PR08MB7343:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JxSw2jx8Lojxr9BJOY4XY1AePFLEHXkt/y2s9kJYAoqOORkspvvuvuZTpyQCBd511mP/gxCQC9i/i4y9NjZX4hZI+gfOnvaFcD/mJ4JtCnaCZyCQbKOhqDysU+LmbFgzAA8eYLQsPY7gXHcW5tjAhcI2UJNinQVi1PSID6wnmPYU89EDHX32EeedfUVAcATliS2R9yrxqWqWdlXcObpO5IpeQF2rI62tqM2Yvaa5Avn3AL9AfAMiJaYBMvu3SGW0VYkP5VAcGPpWEJigaaxn6FvDhatal7dDr9g+UGuADSVRxgT4QTsGQ2YVlfR/OhWP5lOM4gbuXYu9x02ZCReRfjvQAKsBEV8A2mloqNirDtvCRretCKdnuJJEmimp174Ho/rlWujvbykv39mxWrungo6md0W8847mqTpLpnDeDWypa8asiEbDYfKF2QhQclsz5SAmg/7U3PLbPZ2R8+lVYim+K9RvMxzzEL9z5aw2L/ggDn0swCw8zfyN79GMoG8OkrTIezf4D21+iDoSAgoICXTimnvVZ0rwswK7VBRaic/GlausjadbUgkd38olzrnmMPrY3F2xmKcvHrnw8WZPslp0qnpj9+iZflR8h1FwPaESF0rilN/izDkq0FccpLoYDWebcx7hFNclU37XXSDTKWO49Y1TQIG5dsoz6FVfR2zShfL1DbQ3Hlhg0FneUb3maM4CzYvL4zJqX6S/IWXusqvSSFArHMNBNdyEbdJQ2+U= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8676002)(66476007)(2906002)(66946007)(2616005)(66556008)(6512007)(31696002)(86362001)(6506007)(44832011)(53546011)(26005)(508600001)(30864003)(186003)(6486002)(38100700002)(31686004)(8936002)(36756003)(5660300002)(316002)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5315 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fbaedcb0-005b-4841-168a-08da01d87f71 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EpbQ+Dv1Gd/OKsJCcPXy9GwyQOBC+4ZDW+o2XtqgCmCoBpbQDIDOyt7AgjbshedduXLmkRzCSXehnMlxbf4eApYPW7pOeqTZMzTweK+h31PiFsKZW4lPJD+TqfRKgud5LJD1JGXRTS07OeHMVlCaX31okVmxObcDSG9ZCLtfc0HBkq8AkGcH9mWNmJ/XaDO7/v1X8fWJkAVTwmr50tVPfqKtqAGENiaEeamOl/Yenlk+ywm0FAg98HCFtMJyyaMsgzYqfbBWzaAGcCQGLBHeQta5LeG8TqLK7W95qbEZYkLFVPOjhBv9TZUiOwKB8JoZwAOv9AuuKtIp98LjH0Rgs+mTQ0veKBgD3/N2SJkkXLWTcu7COmrjli2Pv3v832Aok5cQob6+H9lFlRFhMjrcRWo5A6QQQ+CjGI7GqVnx0gtMxYgBTo43i5vReY1iV0Os7bLPLlJA6jt6pOsHNCj/pUvxpFaCeyYrlQ9PXCEnhqZtL0ZbE4tYf5MkpYTOgg+t75S/56UbrrBQ47TdV61NYYdyWtIFm4p6b0i+joeo61HWHCRwU2GoV8suzrGJ3DknR8DJovcpwImE/SjJdRdS73Az3zQwh3Xd8qHZVIur59vrpUBRnZl/W1VzK6q6kKuqkUva/NIFRzFFOcqDxRHmXE1YTuGUIybixZOmP9g8BNW4gcyAwVj9ydZYZ6CWlGh1YZ5HILDUjDpXsioCrILsCw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(6486002)(356005)(44832011)(31696002)(36756003)(82310400004)(508600001)(336012)(2906002)(36860700001)(70206006)(316002)(81166007)(70586007)(8676002)(86362001)(31686004)(40460700003)(5660300002)(8936002)(30864003)(26005)(186003)(47076005)(6512007)(53546011)(83380400001)(6506007)(2616005)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2022 14:24:28.6555 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 62622c35-11a8-4950-2844-08da01d8854d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7343 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2022 14:24:35 -0000 Hi, This patch looks OK to me from Arm's backends side. On 3/8/22 12:00, Tiezhu Yang wrote: > It is better to rename floatformats_ia64_quad to floatformats_ieee_quad > to reflect the reality, and then we can clean up the related code. > > Signed-off-by: Tiezhu Yang > --- > gdb/aarch64-tdep.c | 2 +- > gdb/gdbtypes.c | 8 ++++---- > gdb/gdbtypes.h | 2 +- > gdb/hppa-tdep.c | 2 +- > gdb/i386-tdep.c | 2 +- > gdb/ia64-vms-tdep.c | 2 +- > gdb/mips-linux-tdep.c | 12 ++---------- > gdb/mips64-obsd-tdep.c | 6 +----- > gdb/ppc-linux-tdep.c | 4 ++-- > gdb/riscv-tdep.c | 2 +- > gdb/rs6000-tdep.c | 2 +- > gdb/s390-tdep.c | 2 +- > gdb/sparc-tdep.c | 6 +----- > include/floatformat.h | 6 +++--- > libiberty/floatformat.c | 34 +++++++++++++++++----------------- > 15 files changed, 38 insertions(+), 54 deletions(-) > > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c > index b3efb3e..45b592d 100644 > --- a/gdb/aarch64-tdep.c > +++ b/gdb/aarch64-tdep.c > @@ -3582,7 +3582,7 @@ aarch64_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) > set_gdbarch_wchar_signed (gdbarch, 0); > set_gdbarch_float_format (gdbarch, floatformats_ieee_single); > set_gdbarch_double_format (gdbarch, floatformats_ieee_double); > - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); > + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); > set_gdbarch_type_align (gdbarch, aarch64_type_align); > > /* Internal <-> external register number maps. */ > diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c > index f41d6bd..1f8a9e8 100644 > --- a/gdb/gdbtypes.c > +++ b/gdb/gdbtypes.c > @@ -85,6 +85,10 @@ const struct floatformat *floatformats_ieee_double[BFD_ENDIAN_UNKNOWN] = { > &floatformat_ieee_double_big, > &floatformat_ieee_double_little > }; > +const struct floatformat *floatformats_ieee_quad[BFD_ENDIAN_UNKNOWN] = { > + &floatformat_ieee_quad_big, > + &floatformat_ieee_quad_little > +}; > const struct floatformat *floatformats_ieee_double_littlebyte_bigword[BFD_ENDIAN_UNKNOWN] = { > &floatformat_ieee_double_big, > &floatformat_ieee_double_littlebyte_bigword > @@ -105,10 +109,6 @@ const struct floatformat *floatformats_ia64_spill[BFD_ENDIAN_UNKNOWN] = { > &floatformat_ia64_spill_big, > &floatformat_ia64_spill_little > }; > -const struct floatformat *floatformats_ia64_quad[BFD_ENDIAN_UNKNOWN] = { > - &floatformat_ia64_quad_big, > - &floatformat_ia64_quad_little > -}; > const struct floatformat *floatformats_vax_f[BFD_ENDIAN_UNKNOWN] = { > &floatformat_vax_f, > &floatformat_vax_f > diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h > index bd192da..2578b77 100644 > --- a/gdb/gdbtypes.h > +++ b/gdb/gdbtypes.h > @@ -2401,12 +2401,12 @@ extern const struct objfile_type *objfile_type (struct objfile *objfile); > extern const struct floatformat *floatformats_ieee_half[BFD_ENDIAN_UNKNOWN]; > extern const struct floatformat *floatformats_ieee_single[BFD_ENDIAN_UNKNOWN]; > extern const struct floatformat *floatformats_ieee_double[BFD_ENDIAN_UNKNOWN]; > +extern const struct floatformat *floatformats_ieee_quad[BFD_ENDIAN_UNKNOWN]; > extern const struct floatformat *floatformats_ieee_double_littlebyte_bigword[BFD_ENDIAN_UNKNOWN]; > extern const struct floatformat *floatformats_i387_ext[BFD_ENDIAN_UNKNOWN]; > extern const struct floatformat *floatformats_m68881_ext[BFD_ENDIAN_UNKNOWN]; > extern const struct floatformat *floatformats_arm_ext[BFD_ENDIAN_UNKNOWN]; > extern const struct floatformat *floatformats_ia64_spill[BFD_ENDIAN_UNKNOWN]; > -extern const struct floatformat *floatformats_ia64_quad[BFD_ENDIAN_UNKNOWN]; > extern const struct floatformat *floatformats_vax_f[BFD_ENDIAN_UNKNOWN]; > extern const struct floatformat *floatformats_vax_d[BFD_ENDIAN_UNKNOWN]; > extern const struct floatformat *floatformats_ibm_long_double[BFD_ENDIAN_UNKNOWN]; > diff --git a/gdb/hppa-tdep.c b/gdb/hppa-tdep.c > index cf84555..a7d227d 100644 > --- a/gdb/hppa-tdep.c > +++ b/gdb/hppa-tdep.c > @@ -3072,7 +3072,7 @@ hppa_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) > and LP64, but might show differences some day. */ > set_gdbarch_long_long_bit (gdbarch, 64); > set_gdbarch_long_double_bit (gdbarch, 128); > - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); > + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); > > /* The following gdbarch vector elements do not depend on the address > size, or in any other gdbarch element previously set. */ > diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c > index b98f475..b0a5973 100644 > --- a/gdb/i386-tdep.c > +++ b/gdb/i386-tdep.c > @@ -8243,7 +8243,7 @@ i386_floatformat_for_type (struct gdbarch *gdbarch, > || strcmp (name, "real(kind=16)") == 0 > || strcmp (name, "real*16") == 0 > || strcmp (name, "REAL*16") == 0) > - return floatformats_ia64_quad; > + return floatformats_ieee_quad; > > return default_floatformat_for_type (gdbarch, name, len); > } > diff --git a/gdb/ia64-vms-tdep.c b/gdb/ia64-vms-tdep.c > index 23f3265..9b12df4 100644 > --- a/gdb/ia64-vms-tdep.c > +++ b/gdb/ia64-vms-tdep.c > @@ -132,7 +132,7 @@ static struct libunwind_descr ia64_vms_libunwind_descr; > static void > ia64_openvms_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) > { > - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); > + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); > > #ifdef HAVE_LIBUNWIND_IA64_H > /* Override the default descriptor. */ > diff --git a/gdb/mips-linux-tdep.c b/gdb/mips-linux-tdep.c > index 6686355..3f4c1b3 100644 > --- a/gdb/mips-linux-tdep.c > +++ b/gdb/mips-linux-tdep.c > @@ -1556,11 +1556,7 @@ mips_linux_init_abi (struct gdbarch_info info, > set_solib_svr4_fetch_link_map_offsets > (gdbarch, linux_ilp32_fetch_link_map_offsets); > set_gdbarch_long_double_bit (gdbarch, 128); > - /* These floatformats should probably be renamed. MIPS uses > - the same 128-bit IEEE floating point format that IA-64 uses, > - except that the quiet/signalling NaN bit is reversed (GDB > - does not distinguish between quiet and signalling NaNs). */ > - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); > + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); > tramp_frame_prepend_unwinder (gdbarch, > µmips_linux_n32_rt_sigframe); > tramp_frame_prepend_unwinder (gdbarch, &mips_linux_n32_rt_sigframe); > @@ -1572,11 +1568,7 @@ mips_linux_init_abi (struct gdbarch_info info, > set_solib_svr4_fetch_link_map_offsets > (gdbarch, linux_lp64_fetch_link_map_offsets); > set_gdbarch_long_double_bit (gdbarch, 128); > - /* These floatformats should probably be renamed. MIPS uses > - the same 128-bit IEEE floating point format that IA-64 uses, > - except that the quiet/signalling NaN bit is reversed (GDB > - does not distinguish between quiet and signalling NaNs). */ > - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); > + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); > tramp_frame_prepend_unwinder (gdbarch, > µmips_linux_n64_rt_sigframe); > tramp_frame_prepend_unwinder (gdbarch, &mips_linux_n64_rt_sigframe); > diff --git a/gdb/mips64-obsd-tdep.c b/gdb/mips64-obsd-tdep.c > index 0e63d16..8fe2834 100644 > --- a/gdb/mips64-obsd-tdep.c > +++ b/gdb/mips64-obsd-tdep.c > @@ -29,10 +29,6 @@ > #include "mips-tdep.h" > #include "solib-svr4.h" > > -/* The MIPS64 Floating-Point Quad-Precision format is similar to > - big-endian IA-64 Quad-Precision format. */ > -#define floatformats_mips64_quad floatformats_ia64_quad > - > #define MIPS64OBSD_NUM_REGS 73 > > /* Core file support. */ > @@ -150,7 +146,7 @@ mips64obsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) > tramp_frame_prepend_unwinder (gdbarch, &mips64obsd_sigframe); > > set_gdbarch_long_double_bit (gdbarch, 128); > - set_gdbarch_long_double_format (gdbarch, floatformats_mips64_quad); > + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); > > obsd_init_abi(info, gdbarch); > > diff --git a/gdb/ppc-linux-tdep.c b/gdb/ppc-linux-tdep.c > index 0b165fe..63cffbd 100644 > --- a/gdb/ppc-linux-tdep.c > +++ b/gdb/ppc-linux-tdep.c > @@ -1974,7 +1974,7 @@ ppc_floatformat_for_type (struct gdbarch *gdbarch, > || strcmp (name, "_Float64x") == 0 > || strcmp (name, "complex _Float128") == 0 > || strcmp (name, "complex _Float64x") == 0) > - return floatformats_ia64_quad; > + return floatformats_ieee_quad; > > if (strcmp (name, "__ibm128") == 0) > return floatformats_ibm_long_double; > @@ -2053,7 +2053,7 @@ ppc_linux_init_abi (struct gdbarch_info info, > to distinguish between the IBM long double and IEEE quad cases. */ > set_gdbarch_long_double_bit (gdbarch, 16 * TARGET_CHAR_BIT); > if (tdep->long_double_abi == POWERPC_LONG_DOUBLE_IEEE128) > - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); > + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); > else > set_gdbarch_long_double_format (gdbarch, floatformats_ibm_long_double); > > diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c > index 886996c..036577d 100644 > --- a/gdb/riscv-tdep.c > +++ b/gdb/riscv-tdep.c > @@ -3769,7 +3769,7 @@ riscv_gdbarch_init (struct gdbarch_info info, > set_gdbarch_float_bit (gdbarch, 32); > set_gdbarch_double_bit (gdbarch, 64); > set_gdbarch_long_double_bit (gdbarch, 128); > - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); > + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); > set_gdbarch_ptr_bit (gdbarch, riscv_isa_xlen (gdbarch) * 8); > set_gdbarch_char_signed (gdbarch, 0); > set_gdbarch_type_align (gdbarch, riscv_type_align); > diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c > index ee3f051..7016ed3 100644 > --- a/gdb/rs6000-tdep.c > +++ b/gdb/rs6000-tdep.c > @@ -2434,7 +2434,7 @@ rs6000_builtin_type_vec128 (struct gdbarch *gdbarch) > > /* PPC specific type for IEEE 128-bit float field */ > struct type *t_float128 > - = arch_float_type (gdbarch, 128, "float128_t", floatformats_ia64_quad); > + = arch_float_type (gdbarch, 128, "float128_t", floatformats_ieee_quad); > > struct type *t; > > diff --git a/gdb/s390-tdep.c b/gdb/s390-tdep.c > index 153f0ed..cf53c6d 100644 > --- a/gdb/s390-tdep.c > +++ b/gdb/s390-tdep.c > @@ -7038,7 +7038,7 @@ s390_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) > We can safely let them default to 128-bit, since the debug info > will give the size of type actually used in each case. */ > set_gdbarch_long_double_bit (gdbarch, 128); > - set_gdbarch_long_double_format (gdbarch, floatformats_ia64_quad); > + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); > > set_gdbarch_type_align (gdbarch, s390_type_align); > > diff --git a/gdb/sparc-tdep.c b/gdb/sparc-tdep.c > index 03242ed..1d90bb1 100644 > --- a/gdb/sparc-tdep.c > +++ b/gdb/sparc-tdep.c > @@ -61,10 +61,6 @@ struct regset; > code that can handle both. The 64-bit specific code lives in > sparc64-tdep.c; don't add any here. */ > > -/* The SPARC Floating-Point Quad-Precision format is similar to > - big-endian IA-64 Quad-Precision format. */ > -#define floatformats_sparc_quad floatformats_ia64_quad > - > /* The stack pointer is offset from the stack frame by a BIAS of 2047 > (0x7ff) for 64-bit code. BIAS is likely to be defined on SPARC > hosts, so undefine it first. */ > @@ -1838,7 +1834,7 @@ sparc32_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) > tdep->cp0_registers_num = ARRAY_SIZE (sparc32_cp0_register_names); > > set_gdbarch_long_double_bit (gdbarch, 128); > - set_gdbarch_long_double_format (gdbarch, floatformats_sparc_quad); > + set_gdbarch_long_double_format (gdbarch, floatformats_ieee_quad); > > set_gdbarch_wchar_bit (gdbarch, 16); > set_gdbarch_wchar_signed (gdbarch, 1); > diff --git a/include/floatformat.h b/include/floatformat.h > index c851879..ffb02f9 100644 > --- a/include/floatformat.h > +++ b/include/floatformat.h > @@ -97,7 +97,7 @@ struct floatformat > const struct floatformat *split_half; > }; > > -/* floatformats for IEEE single and double, big and little endian. */ > +/* floatformats for IEEE half, single, double and quad, big and little endian. */ > > extern const struct floatformat floatformat_ieee_half_big; > extern const struct floatformat floatformat_ieee_half_little; > @@ -105,6 +105,8 @@ extern const struct floatformat floatformat_ieee_single_big; > extern const struct floatformat floatformat_ieee_single_little; > extern const struct floatformat floatformat_ieee_double_big; > extern const struct floatformat floatformat_ieee_double_little; > +extern const struct floatformat floatformat_ieee_quad_big; > +extern const struct floatformat floatformat_ieee_quad_little; > > /* floatformat for ARM IEEE double, little endian bytes and big endian words */ > > @@ -128,8 +130,6 @@ extern const struct floatformat floatformat_arm_ext_littlebyte_bigword; > /* IA-64 Floating Point register spilt into memory. */ > extern const struct floatformat floatformat_ia64_spill_big; > extern const struct floatformat floatformat_ia64_spill_little; > -extern const struct floatformat floatformat_ia64_quad_big; > -extern const struct floatformat floatformat_ia64_quad_little; > /* IBM long double (double+double). */ > extern const struct floatformat floatformat_ibm_long_double_big; > extern const struct floatformat floatformat_ibm_long_double_little; > diff --git a/libiberty/floatformat.c b/libiberty/floatformat.c > index ce36bae..f93568b 100644 > --- a/libiberty/floatformat.c > +++ b/libiberty/floatformat.c > @@ -78,7 +78,7 @@ floatformat_always_valid (const struct floatformat *fmt ATTRIBUTE_UNUSED, > a system header, what we do if not, etc. */ > #define FLOATFORMAT_CHAR_BIT 8 > > -/* floatformats for IEEE half, single and double, big and little endian. */ > +/* floatformats for IEEE half, single, double and quad, big and little endian. */ > const struct floatformat floatformat_ieee_half_big = > { > floatformat_big, 16, 0, 1, 5, 15, 31, 6, 10, > @@ -127,6 +127,22 @@ const struct floatformat floatformat_ieee_double_little = > floatformat_always_valid, > NULL > }; > +const struct floatformat floatformat_ieee_quad_big = > +{ > + floatformat_big, 128, 0, 1, 15, 16383, 0x7fff, 16, 112, > + floatformat_intbit_no, > + "floatformat_ieee_quad_big", > + floatformat_always_valid, > + NULL > +}; > +const struct floatformat floatformat_ieee_quad_little = > +{ > + floatformat_little, 128, 0, 1, 15, 16383, 0x7fff, 16, 112, > + floatformat_intbit_no, > + "floatformat_ieee_quad_little", > + floatformat_always_valid, > + NULL > +}; > > /* floatformat for IEEE double, little endian byte order, with big endian word > ordering, as on the ARM. */ > @@ -269,22 +285,6 @@ const struct floatformat floatformat_ia64_spill_little = > floatformat_always_valid, > NULL > }; > -const struct floatformat floatformat_ia64_quad_big = > -{ > - floatformat_big, 128, 0, 1, 15, 16383, 0x7fff, 16, 112, > - floatformat_intbit_no, > - "floatformat_ia64_quad_big", > - floatformat_always_valid, > - NULL > -}; > -const struct floatformat floatformat_ia64_quad_little = > -{ > - floatformat_little, 128, 0, 1, 15, 16383, 0x7fff, 16, 112, > - floatformat_intbit_no, > - "floatformat_ia64_quad_little", > - floatformat_always_valid, > - NULL > -}; > > static int > floatformat_ibm_long_double_is_valid (const struct floatformat *fmt,