From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by sourceware.org (Postfix) with ESMTPS id C9CF63858D39 for ; Thu, 9 May 2024 13:27:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C9CF63858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C9CF63858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715261274; cv=none; b=TSdWUmTEeJSd/GfqvlBxnHxODIKZWsLvTf+nGFXeHFbbDsA3tTXJC9vWChlcM2BPJConkjkLK3wMDirhbY53gRmaCqllVBSJtkKn/E7mTOAK80HSrMMrK+2cckmp41f8aiNJkk8Ax3nGaKlvHzpWu38kvhWoewo7vJgZ/aWGEms= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715261274; c=relaxed/simple; bh=pw2+NiKQ790ryAYAKWMftuc1UiNneGvNs+WRedVfWkE=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=t7beekjNL75YBMSqR142j56SZ3BzNOSFOM6r9GOb3CVkfpO0sCQ7vViCNt47RLqSvzcpy6Ya2JOQ8zVhCeYXkJbManMmH5v9O3BLfj7jA9jspchSnPFagkAbMUcNnZBKgMp7gK9X4WfQ6hJKgi6HVi94v0vu8fVCXHBbjcl+Px8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-34e0d47bd98so1081175f8f.0 for ; Thu, 09 May 2024 06:27:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715261272; x=1715866072; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r/7COOQpeiQs2YmU8XRt/pdu5WrLmb+SMhZMx4cpTyU=; b=jNpeIeWZZP/mQsWhvkRuke+MYqd1DQcH0Ye9sCXjJqn+C8GGwSWmeZS1Ncj5LoGv0J lDGWMnw/U6Ued/mfeSxybaXh5mh+u5d9/oTOlxLql9cnKc/gMDRb59X6k3LOx8WE8cHH RZbNf32SyhZR/rrlv3xpNoPWJcvczdJ/luL6StcJWCvhc76xu/vBRiEqEgp4wyV8ityz ojC/EhYLOYrbXGY1b0YUY+qtVlRDXIgHH6kf3G+E8XBIBxLo0kam3rIhwYOHqWqzSh72 rbir4IhtTZG7CJqzOqY+vGKJuP3AiHu44Tv/k5SJHCNFDYJzlowGYDh/zqVxXDBdp7Ub ZtSw== X-Forwarded-Encrypted: i=1; AJvYcCUlVZTjwBxw1hp86hB85z51N2/f2bPGShtSBbbP8OORcmgLF8hHBZMrmq4YWuC/7fFmcz1/o9Wmtu9GpyFW5Wvq0tZX4yOuyz7pjw== X-Gm-Message-State: AOJu0Yy+qz7MRZBvNPfgdt3EY0dUtuNP4Fw8mmBuuo5SBFkR5ypalPk+ BUcpDedHViQ076OgswaBxmSdud8LUar6CwkNOx7GnPJfgIfPPKWf X-Google-Smtp-Source: AGHT+IEIu6oLkT9S9fRU+Z0lEHNFI1hnPbtWnf33RlMi0AHlkP9Stu2TTScsbAyT4z9kWmqn0aqHbw== X-Received: by 2002:adf:cc08:0:b0:343:cee1:cbc1 with SMTP id ffacd0b85a97d-350181150b2mr2399237f8f.14.1715261271443; Thu, 09 May 2024 06:27:51 -0700 (PDT) Received: from ?IPV6:2001:8a0:f908:4900:7b85:4b94:a70:8c25? ([2001:8a0:f908:4900:7b85:4b94:a70:8c25]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3502b79bdbcsm1712297f8f.23.2024.05.09.06.27.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 May 2024 06:27:50 -0700 (PDT) Message-ID: <5d0a74ca-16a8-4a2f-ab84-16976d2599e4@palves.net> Date: Thu, 9 May 2024 14:27:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 31/34 v1.2] Windows gdb+gdbserver: Check whether DBG_REPLY_LATER is available To: Eli Zaretskii Cc: ssbssa@yahoo.de, gdb-patches@sourceware.org References: <20240507234233.371123-1-pedro@palves.net> <20240507234233.371123-32-pedro@palves.net> <86edaca2wi.fsf@gnu.org> <2059403191.787933.1715249225936@mail.yahoo.com> <86zfsz5kly.fsf@gnu.org> <02cbb5f5-c652-4d90-b328-853542e16557@palves.net> <86r0eb5g2n.fsf@gnu.org> From: Pedro Alves Content-Language: en-US In-Reply-To: <86r0eb5g2n.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-05-09 13:24, Eli Zaretskii wrote: >> Date: Thu, 9 May 2024 12:11:40 +0100 >> Cc: gdb-patches@sourceware.org >> From: Pedro Alves >> >> Are we going to trust that all the older supported Windows versions will work >> this way (without testing them all)? WinXP, Win7, etc? If so, I can definitely >> switch to that approach. > > AFAIK, ERROR_INVALID_PARAMETER is the standard response to an > unsupported parameter value, yes. > That part will never in question. As I said earlier, I have seen ERROR_INVALID_PARAMETER errors when you call ContinueDebugEvent at a time when there is no event to continue, because it had been continued already. The error we see when we pass down pid=0 is ERROR_INVALID_HANDLE. But we don't pass a handle down to ContinueDebugEvent, we pass down a pid and a tid. So it could be reasonable for Windows to return ERROR_INVALID_PARAMETER in this situation too. The risk is that some version of Windows does that (either older and newer), and we misdetect the support as non-existing. But we can cross that bridge when we come to it. I'm happy with the approach as is.