From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61341 invoked by alias); 18 May 2018 21:17:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61330 invoked by uid 89); 18 May 2018 21:17:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=remote_target X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 May 2018 21:17:25 +0000 Received: from ESESSHC007.ericsson.se (Unknown_Domain [153.88.183.39]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 09.F5.05787.3E24FFA5; Fri, 18 May 2018 23:17:23 +0200 (CEST) Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSHC007.ericsson.se (153.88.183.39) with Microsoft SMTP Server (TLS) id 14.3.382.0; Fri, 18 May 2018 23:16:25 +0200 Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 18 May 2018 23:16:24 +0200 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 18 May 2018 23:16:24 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.48.114] (192.75.88.130) by SN6PR15MB2400.namprd15.prod.outlook.com (2603:10b6:805:24::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Fri, 18 May 2018 21:16:22 +0000 Subject: Re: [PATCH 06/10] remote: Small cleanup in compare_section_command To: Pedro Alves , References: <20180516141830.16859-1-palves@redhat.com> <20180516141830.16859-7-palves@redhat.com> From: Simon Marchi Message-ID: <5d1f8ac0-3f71-7627-4ec9-d184c977d22e@ericsson.com> Date: Fri, 18 May 2018 21:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180516141830.16859-7-palves@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN6PR1501CA0011.namprd15.prod.outlook.com (2603:10b6:805::24) To SN6PR15MB2400.namprd15.prod.outlook.com (2603:10b6:805:24::20) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:SN6PR15MB2400; X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2400;3:1OiRcbneXJkKrcVE+oF7CuplY4bSK4OM+v79qA0JwT4EhrzJsKt5XZXtnXq4C5GABSYjc7irDF8FNGSHHV8VSi8DdPzMFRzH+39mCVe+NVWTQQNzt6Up5bY/YjCIl34+y4jdCYczZw1wBdWCweDc80oHSKtW49UQEpU5yYlIMh0DOG3Z3Uir6AUBq0ve0wP3dQIL8MQlzCvLeUuhS9h4l5Hpb6vnAtRSXGLUfaCc3y6PZv+JTPscEXvJ7iuIsDga;25:YTZgVCDked2X2COPhGKUO/a0DaqPd7WRYh9eGJu3Ep6MAQF0/DPZU6yVuKcO4nzCP0EgiGGb2+1ZU1RcXOrwk3A+jcHHgL30k9goJKFRjLUA+/QR7cbngCMDia7I4W7oM3y8zBGobTTpeXtnV94clhFKXU+nSv+Bn/qqgAOzyI4kgBYppoUq3XQ2uELuyNQS3Egs4vdzbzqXya4bMygJ3C8BoM4/8+hmMhCCmr44ft5v8yDe4J/1t6iLIQVXkF2Qw3vSH9IXTKYplw1Ts9LzrZ7C3GgnICF7Fozm/Tp/+n9OXO8smiC06DMRE2CRA3QGU5o3XOUlIRwKhOqufuLvgg==;31:UuZVcZ+OWsYXXEjyzacCgbLx1hv+WzFxbvaeCCjLdoSKcEzcAo8n5xxUASeM78/wtv2bFFj+Xr5IofyAT3Iuo+ius40fUmEFYuzrNuQ3YHFVxWf4bedUmQsjgw3qx1d5SP4WFdVfrZUzL/1ENrLjer2tavmndXVPXkRpUVB8pbjFHvmQY5B8HTSfkdFWu4/GBoLP/H9M4nnMk2pCfq4aKQkjeebcIN9CYGU/z7a26KM= X-MS-TrafficTypeDiagnostic: SN6PR15MB2400: X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2400;20:1ZVeeAol2hdl3bFIjvhDFGZrS3moGIcnpV/yLf1c3Q/uiVdp7T9ZlBu2uSbgnyh8A9r/ZaBSwqnbon02hJqaGEHXXCVx46e3x40RRS/I0y7MDKoIT8fxn/RZZcRtHJ3hgLMwh8USTEfciIHacZ1QszgWjEKw06CbF0/tkHDh8b9MZrd6yIBf1J+KAl7toMm2gffnn/MVApwC+zqy0MTlcx8lUdfK1sHugPKtbDWwKetRw1oRSCQ3UXQpTZlx9NOJ+sl+v6Ld5izyua5v69F9ohRcztZ8zpL4gUBac7MRDBgxLeAOQrIXIQsM9VtfQzuADsF0My1g/xIX/7K8cDZ3oUFncM1EAi/IcvLoaYydXjNKeOQakWCV1kB/4eA33T2Jq0OzibduaYgO+k9f9JEVa6OyxOu8CrSrNoCeXGXQZz0YrhJ6c1oGcT7YextEUI4o5WMJOgNCsOh98x114JQqy1+gqiqnmLAMqSU9Q0KEBknNlNnSaJbVPLhsAnlte05o;4:STP4Io4CfFkN5WjXkHHmEAKF30DqorDKKmS8uw6KE33KcoIIYhnXM4g23w7HVfhqcwZL0F/d+0H7n8hvF267VSaydyer5DNbU0gWO0zKL5a7pZR3rYlW5B/2Lv3J9MPEMPXn1+risywUJvIVWi14E1RxbgyiXkuSPp062NxqyUtqi9m7Wq8FX6s+I+Tuu7pjZKW0xuPWIX0/4Put74788SB92Sv9/5lHosw2YWK3mPcJCx7vpBaM2T7tNyfu8K5vjIP7e+ppcPDzzcliwEG4HwyP3O8EBHhgt2mHCYuL9399zpZZO2VUjc2eAmDxhEf9 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(21532816269658); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(149027)(150027)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(6072148)(201708071742011)(7699016);SRVR:SN6PR15MB2400;BCL:0;PCL:0;RULEID:;SRVR:SN6PR15MB2400; X-Forefront-PRVS: 0676F530A9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39380400002)(376002)(39860400002)(366004)(346002)(396003)(199004)(189003)(377424004)(54534003)(81156014)(26005)(81166006)(8676002)(478600001)(8936002)(186003)(53936002)(16576012)(5660300001)(386003)(316002)(58126008)(64126003)(49976009)(6666003)(53546011)(52116002)(76176011)(23676004)(65826007)(229853002)(59450400001)(2486003)(106356001)(105586002)(52146003)(6246003)(50466002)(31686004)(6486002)(11346002)(47776003)(86362001)(2616005)(16526019)(446003)(956004)(68736007)(476003)(6116002)(66066001)(65956001)(97736004)(25786009)(31696002)(2906002)(305945005)(3846002)(486006)(7736002)(230700001)(36756003)(44832011)(65806001)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:SN6PR15MB2400;H:[142.133.48.114];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjZQUjE1TUIyNDAwOzIzOnVzVVF0WUtkR2crd2FwV2hYWDlON2plOVI1?= =?utf-8?B?d1BZMCthR2g2aFRnYjRUTHBMVFkvK3VjbkNlTkdoVXhRZ2RtVkltcjRPNmRO?= =?utf-8?B?cEhCTnBWNGdIdHhTb0tCRG9rZlYya2N3ZFdMOW1LK2NZa2pGMHZKaDFxTCtJ?= =?utf-8?B?d0Q1Um1zeEQybCtZK3ZoRkcyWS9tdG9UajMxQXFlZWRRN2JoL1JSTVZTMFVK?= =?utf-8?B?QnFUdUJrdkh1TnhkUDZxd2tUcEJoZmRwZFlHbVpoZWptUlUyOVVSZ1oxUkRq?= =?utf-8?B?YmE4eTMyaU9QVUJuSWx0NFI1TjE2VmMvb0o3QmQ3MnRoS2s1V0dkcXM4Y3B0?= =?utf-8?B?R2RFR1dFcFAzNjhzc2JWcFI3STN0bkNoWnZrdno4RVcvcXA0czJXd201RmNE?= =?utf-8?B?RHpFb05YNGpwbnAybWhhUHJkRmhkS3c1UW5EcVlYVVFHSFhCdXlSUnV0eTZi?= =?utf-8?B?UlI2T2oyN1h5MXNXdHN5cDd2VXRXMkNRNjFSV1ZFMTEwZ1RxV1RaVndNcWxB?= =?utf-8?B?bHVHeDZRVWhZN1B1YXVKWWE5ZXNyQWpiNjhFVUs2N3hMeWg3V0t1aklVMXdG?= =?utf-8?B?c0pOUVFuU1FhenJsYUx6MUFwTmEwOEpYODUvcGJYTDZ3eGQrd2dLMFd0eEdJ?= =?utf-8?B?M0FDdUo0WWNhQ08xUGoyWHVuVGlSTTI1U2FUdU8yQ3ora1dOM3ZYakxDdGRJ?= =?utf-8?B?Qk9RU2xRVHU5WGgxT3NoQS9XbjdUSC9pR2s3OUFDelZ4V2YzUTRXK3E5QUlu?= =?utf-8?B?OGRaQTIzK25IZElmSmZ2ZmpMSG9HeTlMdHorRnNmU0hhSUhNNnBkaDRsU2Ev?= =?utf-8?B?UkRmV2xNd3dRRG9ZdUJpNGozQkQrb2JmRW14TklDc3dZczNsV1JDZk1GTHVy?= =?utf-8?B?V2VVQVhsUnBHNUpoZmJCREVHQ3UyY3d0RWVpWWMvenU5c2cvZi8wSXI2aVlX?= =?utf-8?B?WVpUM2hWWlhvNlJ6N3RZdU5YWHZZbUJZQUJ3dGVaMXBubE13Q2ZNZ3FTS3dD?= =?utf-8?B?VUtSYlhJQU5BUThmYmIxTzdLeGhXMHJRQzlrek4vUlJVUk1TcE1GL2VHWE1t?= =?utf-8?B?Uk5MeTlaUlF6VEtNcjRNQktYWWZLVG9XcS90ejkwbWFFOWhBSDZKZllMUWR1?= =?utf-8?B?cWloRUxaa3pZNVRPcStoeU5RVDdJYURuNGVqcEhRazBvQ2ZIL2ZnMW8rNFR4?= =?utf-8?B?b1dnZjUvQXV4WnJLMFJ6TzBRVmxKVDlYL1FzRUlLRVNpMFo2VDNpZ3BqazlR?= =?utf-8?B?bkFuc1FsTGFrUloydmpscjRQM3BqOFdLL2pYb0ZDa2hUME5xRXd1bTluL1Zn?= =?utf-8?B?Z21vMWJybnNzeHNHRUoxdnhRUGNsVVR4em5oV25WUXlMQ1BKYUhHcnpOWWY0?= =?utf-8?B?TkNFZkxLMDJpZmhEL1R6NDY4akdVRzBvOW5ITTE0N1BXQ29ZR0pCQmVoNkpD?= =?utf-8?B?aTBxbi8wcG1Oc2JKajBMTzRVQ1FtTXlSRU84M202YVNmaEY5cWJKa2NVTG9U?= =?utf-8?B?aTRrR3ZWK0laTjVUMmZPVkNRVnA0eS93MlNrZC9sTGZDVi9YV2xmYkRabXlJ?= =?utf-8?B?Q0pLSHVmY0FXY0pPK3hUeFdqTXBMUU96TkhCQisyVnBSTVJQMUgxOU9HTjFy?= =?utf-8?B?SllONnhUdFRRWVh4WnlGWHdRU2UvNWFITzB0T0E1SUNteUFwL1FsaiswYyt2?= =?utf-8?B?d3FDd28yY0JucWx5b2dVaUZZZER1UVZDSmk1aEpmR09BMjNIWVdLK01sdG9X?= =?utf-8?B?bXRGOUlVZnJFSEpCTUNra2NTUjQ0REkzbGhEa1gxVmJSc1NhQVZadzJzazZL?= =?utf-8?B?a05FSUFyTThkWmV5d2l4ZklialhJUUNMcFA5QTVNcXA3dDNBcGJ3eVJNbmFi?= =?utf-8?B?b0dWUFBHTUxLeCtuSzRkc0wweEVXd0dwNk5Ob3QzUHk4ckFvZ0I4UkJpdHJZ?= =?utf-8?B?M0VWOUVYZFVZV0cxbkhKdFpJc3FpQ1plSVM3VmhRV0xLN012Sm93OWYvdlMz?= =?utf-8?B?cFBuOWFtVzNJdTNLVVNlbjF4Z2FJSHJseVZUdz09?= X-Microsoft-Antispam-Message-Info: pIeA2mkoGEpSfpdxHvRMri41Uft2y7RPsDymEgYoYQReJsGGIrRcXyyd8fZu/UBvj1SeyIJ8UNujfuO3K1nDBDYWcQ/RSHqw8EAJjD9tN8fcvAhrOailEBoGcR3AGZuF2S7Q/KQ2bLrPQfMFQo6aBZwUi31O0fA3TOHvfNqaO3lNa9D9Jsg/CE9LPjibK940 X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2400;6:84kN+CgrdTGzaVELQuAilQBpr5n3IoNtJmpX8+PoD2ahcUuzkjcRb2/LSTism72k5wCLfTSihNb0o+2iXpR8tSeuJtZGZxHk6DWZAL1S7wKGJ9nQ1kkU9fdctYeq/ZZhHYdxZfC5VoKoBpYiQKM4D6k3I1ZPuv+si+PKEI7RbUlRihS8AUi9v6tXsvY4CQ50MCdEbJuTJz+nG62WqrS43rECXstxuwqFXJw5L2NiFjFLSVq7Uf7S3IlDA+hseGBlAWCTq/BO/rcltk2lJ4+lDHpd1sxPlUNtvf29scJ8P2CG49PmqJUAAeO52GfptOEeGMtAvCEYeucynboaE35yIEOXihyG8V1qXXwIQqpBcIUt294Oo+sY5B7cfzPcZORIK9oc6XIApOugRIvr5W+mUubr3MPtEI6STel5bJ0651yHYSztHMWj5Sxgsi3IEP7FR87lIq8yrZOw4yPlS549Rw==;5:VX/K8VL4lbt7rou8SBYdrPW4AstygrcTdqq26O9Rtz4oGZfz898VmPF8VKsdefliGM4KVMoBHOWo9JJ8EbaIb1PKkb5gjE6GPNrtm8GVURJufDi8fuU8A+LbOVl069LfXfiAhTOnS03Waa1IrXt694/ZTTrSO7J5ZS8lgcEnodA=;24:DFAy/+7ZWFLZ634PfCOk2B644ZTT9mq1mHCbSgbNM/erI5WbR/vUvEBVylChVlAxmJh1AnOKDayHMx8+L00GgSsA6JJdqzjYGcLpL0Pnx4k= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN6PR15MB2400;7:b83jiuWiLQW6o+KKV6oYSfXIJpCVi98kvpx+sTAyjNv9irTwvhn7+Gp/EyVK3gKZWmei+ENmCYVFjGqJ9MsziaWyXEH/b16TadEdB26y1vtgkj/ZyJhLSQDq0rkFeS+LXQDDPag3y4ticzdBVWUwnGvr7PatrHIF4o9KsNXBlHpEA9ZYHPy6jKlV2lvz7qG+rhP5FWXgsAx05DIrH4LjI+vYO+B6zgnJLIWk88Lh+reMsxOCxry5rw9j5umvXxZY X-MS-Office365-Filtering-Correlation-Id: c183c397-70f1-4c5b-e0ba-08d5bd049b7e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2018 21:16:22.6751 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c183c397-70f1-4c5b-e0ba-08d5bd049b7e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR15MB2400 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00426.txt.bz2 On 2018-05-16 10:18 AM, Pedro Alves wrote: > The set_general_process call in compare_sections_command isn't > actually needed. remote_target::verify_memory and > remote_target::xfer_partial already handle making sure the remote is > pointing at the right process or thread. > > Getting this out of the way helps a bit with further elimination of > the remote_state global, because we have to handle the case of a user > invoking the command even if not connect to a remote target. > > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * remote.c (compare_section_command): Remove set_general_process > call. > --- > gdb/remote.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/gdb/remote.c b/gdb/remote.c > index 8e1baf0856..ef15eafe2a 100644 > --- a/gdb/remote.c > +++ b/gdb/remote.c > @@ -10511,9 +10511,6 @@ compare_sections_command (const char *args, int from_tty) > if (!exec_bfd) > error (_("command cannot be used without an exec file")); > > - /* Make sure the remote is pointing at the right process. */ > - set_general_process (); > - > if (args != NULL && strcmp (args, "-r") == 0) > { > read_only = 1; > LGTM. Simon