From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by sourceware.org (Postfix) with ESMTPS id C23573858D1E for ; Sat, 19 Feb 2022 17:49:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C23573858D1E Received: by mail-qk1-x72b.google.com with SMTP id bm39so353645qkb.0 for ; Sat, 19 Feb 2022 09:49:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EhMrX1ur7Fl/ZdBYIBzissssn9aEW+OeloAV8/kAO8k=; b=35oTGMOAQRwSChJ1LnMjZ/PXRrzfsjLtMJWBsMDHwbtd23hGYQ3s6cn/q2hWpNVrHi VyxrtTP/HOX24Lp034eaLSzFw5/oyCHDfBdRqoAUPhLni3P3coc1TL5kQKNrIE5jJ70h BPuRNp5YahlEG8niTQD+7JD6f18M9c4ksieP62HvCv1s/Bjc4Lw4EYp3X2wHd4vdNsZC xE+wcVSKrU6lnYGioVkZyvotr1RquEGQlBQqq/ZHsV3hJNCZFMoQ60KvBUyfNay0OJHg a4WpHAlts7awSwbe3XdTxdhboAE6BY3BWCz4hq10Vf5mkbbmjKm5W4SN/SG7wdAbCs93 nLsQ== X-Gm-Message-State: AOAM5316q+HSPfLg/WbJYIeKnWNyrYlWqHHXEgeHob/SkpsS/BIaoMMq nK4J4SKjD1S9rNWAojyUWtI= X-Google-Smtp-Source: ABdhPJw6mzWSjvG66u7mHL1okm33G+56Y/SO2aZaTTT2dsEQ80QixCdf1xJPHCH3KahEa2NLC8h09w== X-Received: by 2002:a37:bd4:0:b0:606:4caa:650a with SMTP id 203-20020a370bd4000000b006064caa650amr7929155qkl.197.1645292975382; Sat, 19 Feb 2022 09:49:35 -0800 (PST) Received: from [192.168.1.127] (173-246-5-136.qc.cable.ebox.net. [173.246.5.136]) by smtp.gmail.com with ESMTPSA id bq33sm24753715qkb.64.2022.02.19.09.49.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Feb 2022 09:49:34 -0800 (PST) Subject: Re: [RFC][PATCH v2 2/2][PR gdb/24069] [fix] Skip over WIFSTOPPED wait4 status To: Simon Marchi , gdb-patches@sourceware.org Cc: Dominique Quatravaux , Sam Warner , Louis-He <1726110778@qq.com> References: <20210408191449.27434-1-dominique.quatravaux@epfl.ch> <20220216141540.96514-1-levraiphilippeblain@gmail.com> <20220216141540.96514-3-levraiphilippeblain@gmail.com> From: Philippe Blain Message-ID: <5d3db5b1-c5a1-25ec-e82e-717f5cb4235c@gmail.com> Date: Sat, 19 Feb 2022 12:49:33 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Feb 2022 17:49:37 -0000 Hi Simon, Le 2022-02-19 à 10:59, Simon Marchi a écrit : >> diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c >> index 8b0ecfd5b77..a3c6a978676 100644 >> --- a/gdb/darwin-nat.c >> +++ b/gdb/darwin-nat.c >> @@ -1063,7 +1063,7 @@ darwin_nat_target::decode_message (mach_msg_header_t *hdr, >> } >> else if (hdr->msgh_id == 0x48) >> { >> - /* MACH_NOTIFY_DEAD_NAME: notification for exit. */ >> + /* MACH_NOTIFY_DEAD_NAME: notification for exit *or* WIFSTOPPED. */ > > Two spaces after period. > >> int res; >> >> res = darwin_decode_notify_message (hdr, &inf); >> @@ -1103,16 +1103,26 @@ darwin_nat_target::decode_message (mach_msg_header_t *hdr, >> return minus_one_ptid; >> } >> if (WIFEXITED (wstatus)) >> - status->set_exited (WEXITSTATUS (wstatus)); >> + { >> + status->set_exited (WEXITSTATUS (wstatus)); >> + inferior_debug (4, _("darwin_wait: pid=%d exit, status=0x%x\n"), >> + res_pid, wstatus); >> + } >> + else if (WIFSTOPPED (wstatus)) >> + { >> + status->set_ignore (); >> + inferior_debug (4, _("darwin_wait: pid %d received WIFSTOPPED\n"), >> + res_pid); >> + return minus_one_ptid; > > Can you add a comment explaining that the stop will be handled by a > following exception? It can be confusing why we ignore a WIFSTOPPED. A > bit like you explained in your commit message: > > - Read and ignore such messages (counting on the next exception > message to let us know of the inferior's new state again) > > > >> + } >> else >> { >> status->set_signalled >> (gdb_signal_from_host (WTERMSIG (wstatus))); >> + inferior_debug (4, _("darwin_wait: pid=%d received signal %d\n"), >> + res_pid, status->sig()); >> } > > Can you replace the else with > > else if (WIFSIGNALED (wstatus)) > > and add an else with a warning like: > > warning (_("Unexpected wait status after MACH_NOTIFY_DEAD_NAME " > "notification: 0x%x"), wstatus); > > I think that having this warning would have made the bug you fix more > visible, so easier to find. Perhaps it will help catch another similar > problem in the future. > > The else should probably do status->set_ignore () and return > minus_one_ptid. > > Simon > I'll address your feedback and send a v3 for 2/2. Thanks! Philippe.