From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128239 invoked by alias); 21 Jun 2018 19:19:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128215 invoked by uid 89); 21 Jun 2018 19:19:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Jun 2018 19:19:22 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w5LJJFIU003869 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Jun 2018 15:19:20 -0400 Received: by simark.ca (Postfix, from userid 112) id B32C01EF2A; Thu, 21 Jun 2018 15:19:15 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 3DBBD1E529; Thu, 21 Jun 2018 15:19:13 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 21 Jun 2018 19:19:00 -0000 From: Simon Marchi To: "Maciej W. Rozycki" Cc: Simon Marchi , gdb-patches@sourceware.org, binutils@sourceware.org, Joel Brobecker , Fredrik Noring Subject: Re: [PATCH v4] GDB PR tdep/8282: MIPS: Wire in `set disassembler-options' In-Reply-To: References: <3bd95a5f-e43e-2efe-e261-c2cf30d06d14@ericsson.com> Message-ID: <5d5b6d47508d5f54ff2eb6e514a7da2c@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 21 Jun 2018 19:19:15 +0000 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00529.txt.bz2 On 2018-06-21 14:28, Maciej W. Rozycki wrote: > Hi Simon, > >> This patch looks good from the GDB side (with one nit in the test >> below), but >> somebody from binutils would need to review the bits in >> opcodes/include. > > Yes, that's why I requested it separately and posted to both mailing > lists. > >> > +# Verify ABI overrides. >> > +mips_disassemble_test bar "move\t\\\$2,\\\$8" "disassemble ABI (numeric)" >> > +gdb_test "set disassembler-options" >> > +gdb_test "set mips abi o32" >> > +mips_disassemble_test bar "move\tv0,t0" "disassemble ABI (o32)" >> > +gdb_test "set mips abi n32" >> > +mips_disassemble_test bar "move\tv0,a4" "disassemble ABI (n32)" >> > +gdb_test "set mips abi n64" >> > +mips_disassemble_test bar "move\tv0,a4" "disassemble ABI (n64)" >> >> Avoid parenthesis at the end of test names: >> >> >> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages > > Thanks for the pointer. Although it makes sense to me at first glance > that's quite a recent change to a long-established practice. Perhaps > it > could have been avoided by coding the regression analysis tools > referred > more carefully, but I won't be questioning the decision at this point. That's because of how DejaGNU formats test messages, for example when there is a timeout (as shown in the example on the wiki). We don't have control over that, and we don't want "foo" and "foo (timeout)" to be considered as two different tests. > The wiki does not indicate a suggested replacement however and I would > rather avoid creating a mess where individual tests would use different > approaches. Offhand I'd be inclined to use brackets, either square or > angled. What has been the new practice then? Often, parenthesis would be used when the same series of tests are ran with different settings. For example: foo (non-stop) bar (non-stop) foo (all-stop) bar (all-stop) For this it's useful to use prefixes, with with_test_prefix, for example. with_test_prefix "non-stop" { ... } with_test_prefix "all-stop" { ... } Or even foreach_with_prefix mode {all-stop non-stop} { ... } That does not really apply to your case though. I think here you can just remove the parenthesis, and maybe add a comma. mips_disassemble_test bar "move\tv0,a4" "disassemble ABI, n64" As long as it's clear. Simon