From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 851FA39B4017 for ; Sat, 7 Aug 2021 01:03:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 851FA39B4017 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A69E121B10; Sat, 7 Aug 2021 01:03:28 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 8C65913A64; Sat, 7 Aug 2021 01:03:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id HM1pIODbDWEiGAAAGKfGzw (envelope-from ); Sat, 07 Aug 2021 01:03:28 +0000 Subject: Re: [PATCH 1/5] Remove gdb/testsuite/configure To: Tom Tromey , gdb-patches@sourceware.org References: <20210528192743.508390-1-tromey@adacore.com> <20210528192743.508390-2-tromey@adacore.com> From: Tom de Vries Message-ID: <5d62daf3-7d0d-27cb-3c70-610dae53cbfe@suse.de> Date: Sat, 7 Aug 2021 03:03:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210528192743.508390-2-tromey@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Aug 2021 01:03:30 -0000 On 5/28/21 9:27 PM, Tom Tromey wrote: > I didn't see a strong reason to have a separate configure script in > gdb/testsuite, so this patch removes it. FTR. AFAIU this has been reverted, but when building and testing gdb-11-branch using an older snapshot still containing this change (gdb-11.0.90.20210706.tar.xz), I ran into make check// no longer working. The make target rule tests for [ -f testsuite/config.status ], which is no longer generated after this patch. Thanks, - Tom