From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id F008B3858281 for ; Tue, 27 Sep 2022 10:34:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F008B3858281 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-494-312890McPP-15TpUMQltEw-1; Tue, 27 Sep 2022 06:34:31 -0400 X-MC-Unique: 312890McPP-15TpUMQltEw-1 Received: by mail-wr1-f69.google.com with SMTP id i27-20020adfaadb000000b0022a48b6436dso2020844wrc.23 for ; Tue, 27 Sep 2022 03:34:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=ttMfBIKSMmZhoCYNUF8TMQi069OW4L+h6yepKi6azRs=; b=Vp9Gang7DpgeA5EVPMb736b7DpdATBlxCxrYnE4EUhPNfZIC2YHHfJJFkkML4NPbOo 23QuDSYvf2Jz/yE1vi2XyIaSnGXiTLvpXN3eAgc/8jQNmdgcRi300IctdM38RJDB6bmu RHtGxhQEWxUULx/a8hPzeV/gyV2JSz9dQUSYpPrkVjP4FdJnGtlnbOW9yeI0qSw6mB+Z D7gs8eLLBVrikG1wU1uo9EXNW4xoojAKbEv7A8qncZJUVZt7QvdtUEte4BHXUdLJa/hG zY6gVBQQkYY3ZcxpHVitMpfjZ/vgnP1QyTqxYkp4pSiLSa87Cw8KaFG9atXEe9n+E32C 2Ybg== X-Gm-Message-State: ACrzQf0eijY4ayENmIfZsFFj7mp/FamumHjVJkJZ480DM8r+Uf8mFdZE vcJCaWrwgBI9FlNJvqwoZqteeTWPysPcBMvpH7TT7lkExn/KAca0U0NIz7RKU+gPsvMMna8OU9p tMM7lfx6tYiyQ9iNQLzHThw== X-Received: by 2002:a05:600c:1f0d:b0:3b4:ba4d:272a with SMTP id bd13-20020a05600c1f0d00b003b4ba4d272amr2120432wmb.105.1664274870366; Tue, 27 Sep 2022 03:34:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7mO4+kQpa/KtvUiDATSsxpQimwr2Q9kHQJRSlmZkrliQk4VGrZQPhovMIj9dyFoEVxUhZiHQ== X-Received: by 2002:a05:600c:1f0d:b0:3b4:ba4d:272a with SMTP id bd13-20020a05600c1f0d00b003b4ba4d272amr2120415wmb.105.1664274870171; Tue, 27 Sep 2022 03:34:30 -0700 (PDT) Received: from [192.168.0.45] (ip-62-245-66-121.bb.vodafone.cz. [62.245.66.121]) by smtp.gmail.com with ESMTPSA id t11-20020a05600c41cb00b003b31fc77407sm13381669wmh.30.2022.09.27.03.34.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 03:34:29 -0700 (PDT) Message-ID: <5d6abf06-bda0-15a2-7579-0f0c76c70ac5@redhat.com> Date: Tue, 27 Sep 2022 12:34:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 0/3] Fix gdb.gdb/python-helper.exp + cleanups To: Simon Marchi , Tom de Vries , Luis Machado , gdb-patches@sourceware.org References: <20220923141801.1106678-1-simon.marchi@polymtl.ca> <4fe6a9e7-9b87-2755-b741-3a06180cdcc3@suse.de> From: Bruno Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2022 10:34:34 -0000 On 26/09/2022 20:01, Simon Marchi via Gdb-patches wrote: > > On 2022-09-23 17:35, Tom de Vries wrote: >> On 9/23/22 19:02, Luis Machado via Gdb-patches wrote: >>> On 9/23/22 15:17, Simon Marchi via Gdb-patches wrote: >>>> My patches that touched TYPE_LENGTH and TYPE_TARGET_TYPE caused >>>> regressions in gdb.gdb/python-helper.exp.  I forgot to update >>>> gdb-gdb.py.in, as always. >>>> >>>> It looks like my CI doesn't run the test properly.  Because inserting the >>>> first breakpoint times out, do_self_tests skips the test.  I also had >>>> troubles running the test locally due to these timeouts.  So the first >>>> two patches address problems related to that, and the third one is the >>>> actual fix. >>>> >>>> Simon Marchi (3): >>>>    gdb/testsuite: bump duration for the whole test in do_self_tests >>>>    gdb/testsuite: use gdb_test in gdb.gdb/python-helper.exp >>>>    gdb/testsuite: update field names in gdb-gdb.py.in >>>> >>>>   gdb/gdb-gdb.py.in                       |  4 +- >>>>   gdb/testsuite/gdb.gdb/python-helper.exp | 88 +++++-------------------- >>>>   gdb/testsuite/lib/gdb.exp               |  8 +-- >>>>   gdb/testsuite/lib/selftest-support.exp  | 36 +++------- >>>>   4 files changed, 31 insertions(+), 105 deletions(-) >>>> >>>> >>>> base-commit: 8e037eae6823caf5b9cb5b4feb3de838abb25956 >>> Thanks for the series. I tested this on my end and it seems to work nicely. >>> >>> The only hiccup I noticed is when GDB runs into a SIGSEGV due to the guile >>> interpreter hitting GC_find_limit_with_bound. I'm not sure why this happens. Maybe >>> it is a problem with guile and armhf. >> It's documented behaviour of libgc1, see >> https://sourceware.org/bugzilla/show_bug.cgi?id=29325 . > Ack, this is an orthogonal issue (and for some reason I don't see it on > my Arch Linux, but I have certainly seen it elsewhere). This bug happens because of an old version of libgc being used, where they used that segfault to probe memory for something. They have developed a new way of probing that doesn't trigger this segfault, but not all distributions seem to have backported it. It's probably not happening on Arch because htey have a new version of the library, while on fedora it was happening until recently (Alexandra backported that for us). Fixing this sort of needs to happen on a per-distro basis, as it isn't GDB related, it's an "available libraries" problem. Cheers, Bruno > > Just to confirm, does the series look good to you too Tom? > > Simon >