From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 989833858D28 for ; Wed, 2 Aug 2023 00:03:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 989833858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6AF3E21B9D; Wed, 2 Aug 2023 00:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690934588; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jZdRGogI6fr0WJnyDEXyaeGH3E0TycjfFtbVJEGIVGA=; b=d7Vw+hl/OZny4mDDkEowgDCkbhok4LNLKxnIpc0Sn1qcYfDapCQ//g1AU9tn8r4PCQ7DCy IzpDNBkOI58gUY7WVj/20KE3q8cG5Lix/N6uuU1v86Pu6yQNDAUTULhEDvZIcC4Sf2KZwc 8WEeFt4dgvlWPYaReTnSQBjbcvnssPc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690934588; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jZdRGogI6fr0WJnyDEXyaeGH3E0TycjfFtbVJEGIVGA=; b=mBhaFPhd0JI7p0V8OnEugXGfYpuIX2r0OtbFxfOYjgQiii+MaPmOI85f71nLsKVYPrIytI eqUUD9ONBDb+D5DA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5603C13591; Wed, 2 Aug 2023 00:03:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bGvkEzydyWSNZAAAMHmgww (envelope-from ); Wed, 02 Aug 2023 00:03:08 +0000 Message-ID: <5d7c9731-5c3c-5b07-17a3-d5f2eb2de7f4@suse.de> Date: Wed, 2 Aug 2023 02:02:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix bug in fixed-point handling Content-Language: en-US To: Tom Tromey Cc: Tom Tromey via Gdb-patches References: <20230719152442.67508-1-tromey@adacore.com> <87zg3cf33d.fsf@tromey.com> <1f4e795f-32c2-321d-d7f9-62a51437f513@suse.de> <87v8dyg79g.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87v8dyg79g.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/1/23 16:35, Tom Tromey wrote: > Tom> Test-case fails with gcc-9 and earlier: > Tom> ... > Tom> (gdb) PASS: gdb.ada/fixed_points.exp: scenario=all: print fp4_var / 1 > Tom> p Float(Another_Fixed) = Float(Another_Delta * 5)^M > Tom> No definition of "another_delta" in current context.^M > Tom> (gdb) FAIL: gdb.ada/fixed_points.exp: scenario=all: value of another_fixed > Tom> ... > > Did you happen to try with GCC 10? > Yes, the test-cases passes for gcc 10, 11 and 12, and fails for gcc 7, 8 and 9. > I'm wondering if the appended is enough or if it should be conditional > on gcc 10 specifically. > With the patch applied, it passes for all the above. Thanks, - Tom > diff --git a/gdb/testsuite/gdb.ada/fixed_points.exp b/gdb/testsuite/gdb.ada/fixed_points.exp > index 2edc63f4071..12f1adfc249 100644 > --- a/gdb/testsuite/gdb.ada/fixed_points.exp > +++ b/gdb/testsuite/gdb.ada/fixed_points.exp > @@ -90,8 +90,8 @@ foreach_with_prefix scenario {all minimal} { > # This only started working in GCC 11. > if {$scenario == "minimal" && [test_compiler_info {gcc-11-*}]} { > gdb_test "print fp5_var" " = 3e-19" > - } > > - gdb_test "p Float(Another_Fixed) = Float(Another_Delta * 5)" "true" \ > - "value of another_fixed" > + gdb_test "p Float(Another_Fixed) = Float(Another_Delta * 5)" "true" \ > + "value of another_fixed" > + } > }