From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-041.btinternet.com (mailomta14-sa.btinternet.com [213.120.69.20]) by sourceware.org (Postfix) with ESMTPS id 8607A3844038 for ; Fri, 3 Jul 2020 13:14:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8607A3844038 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=jon.turney@dronecode.org.uk Received: from sa-prd-rgout-003.btmx-prd.synchronoss.net ([10.2.38.6]) by sa-prd-fep-041.btinternet.com with ESMTP id <20200703131430.EJTV7327.sa-prd-fep-041.btinternet.com@sa-prd-rgout-003.btmx-prd.synchronoss.net>; Fri, 3 Jul 2020 14:14:30 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com X-Originating-IP: [31.51.206.31] X-OWM-Source-IP: 31.51.206.31 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeduiedrtdeigdeivdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeeguefhkedvfeeigefhhedtjeehieegtdehhffhheffgfehheegtdffleejteeuueenucfkphepfedurdehuddrvddtiedrfedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurdduuddungdpihhnvghtpeefuddrhedurddvtdeirdefuddpmhgrihhlfhhrohhmpeeojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhequceuqfffjgepkeeukffvoffkoffgpdhrtghpthhtohepoehguggsqdhprghttghhvghssehsohhurhgtvgifrghrvgdrohhrgheqpdhrtghpthhtohepoehsihhmrghrkhesshhimhgrrhhkrdgtrgeq X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.111] (31.51.206.31) by sa-prd-rgout-003.btmx-prd.synchronoss.net (5.8.340) (authenticated as jonturney@btinternet.com) id 5ED9AFBE04FDABE0; Fri, 3 Jul 2020 14:14:30 +0100 Subject: Re: [PATCH 6/7] Promote windows_core_xfer_shared_libraries and windows_core_pid_to_str To: gdb-patches@sourceware.org References: <20200701213225.14144-1-jon.turney@dronecode.org.uk> <20200701213225.14144-7-jon.turney@dronecode.org.uk> Cc: Simon Marchi From: Jon Turney Message-ID: <5dcbc35c-d0dc-1ae2-61e3-a9abf5d984bc@dronecode.org.uk> Date: Fri, 3 Jul 2020 14:14:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2020 13:14:32 -0000 On 03/07/2020 00:56, Simon Marchi wrote: > On 2020-07-02 7:53 p.m., Simon Marchi wrote: >> On 2020-07-01 5:32 p.m., Jon Turney wrote: >>> Move windows_core_xfer_shared_libraries() and windows_core_pid_to_str() >>> to windows-tdep, use in amd64-windows-tdep.c to handle Cygwin x86_64 >>> core dumps. >> >> As a convention, the _initialize function is always at the bottom of the file, >> so I'd put the new functions in windows-tdep.c just above it. >> >> Were the functions copied as-is, or did you need to make changes to support 64-bits? > > Well, right after writing this I saw patch 7, "Add handling for 64-bit module addresses > in Cygwin core dumps". Now you know that I read series in a very linear fashion :). > > So, I suppose that in this patch, the functions are copied as-is, and are not suitable > yet for the 64-bit cores? Yes, this patch is just moves the code, but makes no changes.