From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/6] Use function_view in gdb_bfd_lookup_symbol
Date: Tue, 28 Mar 2023 09:23:58 -0400 [thread overview]
Message-ID: <5e016cd7-8781-47ec-6697-0f80905519bf@simark.ca> (raw)
In-Reply-To: <20230321-submit-unrelocated-type-v1-1-2a1fb6117abf@tromey.com>
> @@ -1675,10 +1673,8 @@ gdb_bfd_read_elf_soname (const char *filename)
> if symbol is not found. */
>
> static CORE_ADDR
> -bfd_lookup_symbol_from_dyn_symtab (bfd *abfd,
> - int (*match_sym) (const asymbol *,
> - const void *),
> - const void *data)
> +bfd_lookup_symbol_from_dyn_symtab
> + (bfd *abfd, gdb::function_view<bool (const asymbol *)> match_sym)
You fixed "Return NULL" to "Return 0" in the doc for the other function.
You could do it for the documentation of
bfd_lookup_symbol_from_dyn_symtab as well.
Otherwise, LGTM.
Simon
next prev parent reply other threads:[~2023-03-28 13:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 19:18 [PATCH 0/6] Use unrelocate_addr in more places Tom Tromey
2023-03-21 19:18 ` [PATCH 1/6] Use function_view in gdb_bfd_lookup_symbol Tom Tromey
2023-03-28 13:23 ` Simon Marchi [this message]
2023-03-28 21:17 ` Tom Tromey
2023-03-21 19:18 ` [PATCH 2/6] Move definition of unrelocated_addr earlier Tom Tromey
2023-03-21 19:18 ` [PATCH 3/6] Use unrelocated_addr in partial symbol tables Tom Tromey
2023-03-21 19:18 ` [PATCH 4/6] Use unrelocated_addr in psymbols Tom Tromey
2023-03-21 19:18 ` [PATCH 5/6] Use unrelocated_addr in minimal symbols Tom Tromey
2023-03-28 13:46 ` Simon Marchi
2023-03-28 21:23 ` Tom Tromey
2023-03-30 3:52 ` Thiago Jung Bauermann
2023-04-03 15:04 ` Tom Tromey
2023-04-04 18:05 ` Thiago Jung Bauermann
2023-03-21 19:18 ` [PATCH 6/6] Rename "raw" to "unrelocated" Tom Tromey
2023-03-28 12:36 ` [PATCH 0/6] Use unrelocate_addr in more places Alexandra Petlanova Hajkova
2023-03-28 21:23 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e016cd7-8781-47ec-6697-0f80905519bf@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).