From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75279 invoked by alias); 10 Jun 2018 22:26:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75100 invoked by uid 89); 10 Jun 2018 22:26:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 10 Jun 2018 22:26:17 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4D5941E529; Sun, 10 Jun 2018 18:26:16 -0400 (EDT) Subject: Re: [PATCH v2 04/10] Add regcache raw_compare method To: Alan Hayward , Simon Marchi Cc: "gdb-patches@sourceware.org" , nd References: <20180606151629.36602-1-alan.hayward@arm.com> <20180606151629.36602-5-alan.hayward@arm.com> From: Simon Marchi Message-ID: <5e17d11e-dd8d-dbf2-944d-7033be37ff3a@simark.ca> Date: Sun, 10 Jun 2018 22:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00260.txt.bz2 On 2018-06-08 11:16 AM, Alan Hayward wrote: > diff --git a/gdb/common/common-regcache.h b/gdb/common/common-regcache.h > index 29d9a81182ad1a5797b080e136b682fe59ecef37..fe3ece7ac52d60d07d718ad617f30be2f7133b5f 100644 > --- a/gdb/common/common-regcache.h > +++ b/gdb/common/common-regcache.h > @@ -75,6 +75,11 @@ struct reg_buffer_common > > /* Collect register REGNUM from REGCACHE and store its contents in BUF. */ > virtual void raw_collect (int regnum, void *buf) const = 0; > + > + /* Compare the contents of the register stored in the regcache (ignoring the > + first OFFSET bytes) to the contents of BUF (without any offset). Returns > + True if the same. */ True -> true (since it's written this way in C++, unlike Python for example). LGTM with that fixed. Simon