From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: remove unneeded argument in check_multi_target_resumption
Date: Wed, 17 Mar 2021 13:06:48 +0000 [thread overview]
Message-ID: <5e1b3ac1-8ad6-a59b-447c-07fd0264c4b3@palves.net> (raw)
In-Reply-To: <20210113044456.2362936-1-simon.marchi@polymtl.ca>
On 13/01/21 04:44, Simon Marchi via Gdb-patches wrote:
> If we reach the modified line, resume_target is necessarily nullptr,
> because of the check at the beginning of the function. So we'll
> necessarily iterate on all non-exited inferiors (across all targets),
> which is what we want, I believe. So the code seems to be correct, just
> remove the unnecessary argument.
>
> gdb/ChangeLog:
>
> * infrun.c (check_multi_target_resumption): Remove argument to
> all_non_exited_inferiors.
>
> Change-Id: If95704915dca19599d5f7f4732bbd6ccd20bf6b4
Agreed. I went ahead and merged it, with a slightly modified commit log.
Thanks,
Pedro Alves
prev parent reply other threads:[~2021-03-17 13:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 4:44 Simon Marchi
2021-03-17 13:06 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e1b3ac1-8ad6-a59b-447c-07fd0264c4b3@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).