From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 44451383E800 for ; Thu, 21 May 2020 14:27:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 44451383E800 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-461-4SDdOxLlOiK5mtMIgnCL1Q-1; Thu, 21 May 2020 10:27:13 -0400 X-MC-Unique: 4SDdOxLlOiK5mtMIgnCL1Q-1 Received: by mail-wm1-f70.google.com with SMTP id n66so2757716wme.4 for ; Thu, 21 May 2020 07:27:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k+upj+Lm7MCqxE7KBubB2znV7bJdBJzhT6oq2vq+FM0=; b=L2Ur9jAsbOLLrX+y75eUnwVdof8hddAG8RsunC99jfUugiWAh74ZvLIG2eLNVJQh3Y 1gbDuP0liLZV4GRybUd1Yh/OZ1RnOTPeaRarRDZsTUOUBwYbt+MrSE81tRdsqrpw0nTP Cd1/NymEtupdFufS13r2Lr6zokaF0n+hRJPHNsV0CQricryS+LpWHesfXU0DrRKduihm SWPWBXNDcZlsqgYcdYo/HVm28GAix5oazXF4Wld3v8x86b2rlbiVT5Ym70NwsQ6CqjOJ Hejxk4tGqKXJ1O56ocusZHQY8IVtCQHVEK7FJzH/8ddjpMLGJNvO+H5lcwZLDJi7ejqX ooXw== X-Gm-Message-State: AOAM532RIRvHgD8mockcSiwYArvozCJwES+J5ixaQDzlGQ/XQPSseZzf Ire3P4L2MrsukTtfbUbo8q9Sz1+1xDdgzSJtIMNuXEqlKDkBOWwmq6UFnm402lGkE0pRiD1urdl GWa16srMmoVTsvy1AGkZQaQ== X-Received: by 2002:a1c:1b44:: with SMTP id b65mr9617014wmb.181.1590071231576; Thu, 21 May 2020 07:27:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBfm6mhjXtmP1XrLueUGX48mB6WjZ4tvvYAebh+/OFvXhSmnj8k2kFAjK1U41d9lNSvHdycQ== X-Received: by 2002:a1c:1b44:: with SMTP id b65mr9617003wmb.181.1590071231383; Thu, 21 May 2020 07:27:11 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id r5sm1962704wrq.0.2020.05.21.07.27.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2020 07:27:10 -0700 (PDT) Subject: Re: [PATCH v2 3/3] Make exec-file-mismatch compare build IDs To: Philippe Waroquiers , Tom Tromey , Pedro Alves via Gdb-patches References: <20200517180450.14925-1-palves@redhat.com> <20200517180450.14925-4-palves@redhat.com> <87tv0b7vy0.fsf@tromey.com> <6d669d00-236a-cede-5c5e-3d65d3ee5a53@redhat.com> <4719db5fbbd5f3b4026bf4b7637ce922d24e8c6b.camel@skynet.be> <437fb053-a1e0-67de-0f0e-6a14fb95bf90@redhat.com> <68ef5273df5458656d57c8154a09f26a2d43dab9.camel@skynet.be> From: Pedro Alves Message-ID: <5e21ba84-7eed-de60-d00b-9f81661dbbc1@redhat.com> Date: Thu, 21 May 2020 15:27:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <68ef5273df5458656d57c8154a09f26a2d43dab9.camel@skynet.be> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2020 14:27:16 -0000 On 5/21/20 3:23 PM, Philippe Waroquiers wrote: > On Thu, 2020-05-21 at 15:02 +0100, Pedro Alves wrote: >> It looks to me like GDB is doing the validation too soon. It should figure out >> that the local file changed, and thus reload it (the "re-reading symbols"), and only >> after, should it do validation? After re-reading, the build ids should match again. >> Or do the "has changed, re-reading" thing earlier, but not sure that's practical. > > Yes, doing the build-id comparison later should solve that behaviour. > If you want, I can take a look at this, sometime this week-end probably. That would be super! Thanks, Pedro Alves