public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Phil Muldoon <pmuldoon@redhat.com>
To: "gdb@sourceware.org" <gdb-patches@sourceware.org>
Subject: GDB fails to build with Python 3.7
Date: Tue, 29 May 2018 13:07:00 -0000	[thread overview]
Message-ID: <5e55cd3c-7ccd-4cce-5297-ddddadf91975@redhat.com> (raw)

Currently GDB fails to build with Python 3.7

https://bugs.python.org/issue33470

This is because we use an internal Python API:

#ifdef IS_PY3K
  gdb_module = PyModule_Create (&python_GdbModuleDef);
  /* Add _gdb module to the list of known built-in modules.  */
  _PyImport_FixupBuiltin (gdb_module, "_gdb");
#else
  gdb_module = Py_InitModule ("_gdb", python_GdbMethods);
#endif

(the _PyImport_FixupBuiltin in python.c).

This internal API has been changed. According to the advice of the Python
maintainers we should never have used it in the first place. I didn't
add this (at least I don't think I did!), so I'm asking whomever
authored that code to please change it to be 3.7 compatible. I'm not
sure what the code achieves so I'm reluctant to touch it in case of
breakages on platforms I don't have easily access to.


Cheers

Phil

             reply	other threads:[~2018-05-29 11:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 13:07 Phil Muldoon [this message]
2018-05-30 23:05 ` Joel Brobecker
2018-05-31 14:43   ` Paul.Koning

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e55cd3c-7ccd-4cce-5297-ddddadf91975@redhat.com \
    --to=pmuldoon@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).