From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 856313858D1E for ; Fri, 24 Mar 2023 17:23:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 856313858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.42.115] (modemcable092.73-163-184.mc.videotron.ca [184.163.73.92]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1692A1E110; Fri, 24 Mar 2023 13:23:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1679678631; bh=yMk4d8D/pg7wRLYAnTkXgHoNqxB/EY8EFG/8I9NrsIo=; h=Date:Subject:To:References:From:In-Reply-To:From; b=RIfK2upjijC2WQdSx31uvkgmOXkd1fnMXiqFeJ7Ky2igRXfCW9HsxvvF+CEHx4fAw 7XlqeyYSDEhPXmlV5jLof6/oZVL/sZTW95FUA7FRbYMPK0p5cqc+fnmjb9vXbnBU8X xPZ03iqCDuGdhyQG/uOd8vSHBS1c5R9sc5TaEaJs= Message-ID: <5e60a837-b21c-011f-c94e-e8bbf7645c5d@simark.ca> Date: Fri, 24 Mar 2023 13:23:50 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 2/2 ] PowerPC: fix for gdb.reverse/finish-precsave.exp and gdb.reverse/finish-reverse.exp Content-Language: fr To: Carl Love , Tom de Vries , Ulrich Weigand , "gdb-patches@sourceware.org" , Bruno Larsen , "pedro@palves.net" References: <65d44121-65f7-a212-79ec-07ce53c15ecb@suse.de> <9fe94c0979cb40979b0dea7693a901c2d9f66164.camel@us.ibm.com> <59417813-eb4a-baf8-4e5d-e225d6732f71@suse.de> <7a494157-494f-6adf-d533-bf373b0f054f@redhat.com> <71aa635593df0677811afb85409aa190bcfa4f6a.camel@us.ibm.com> <15864a6b87b25c93e99a28149f23138267735f2a.camel@us.ibm.com> <041f62e9f26fd4a536bc90c34f072985582e6237.camel@de.ibm.com> <46c2c756475ba5923d7eed97996632a08285dd42.camel@us.ibm.com> <65861786-069e-53a1-ca17-a525b6629c95@suse.de> <5be0c849abeef84d34a6ff255fb2705ca5dcb035.camel@us.ibm.com> From: Simon Marchi In-Reply-To: <5be0c849abeef84d34a6ff255fb2705ca5dcb035.camel@us.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_MANYTO,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/1/23 15:59, Carl Love via Gdb-patches wrote: > Tom, Ulrich, Bruno, Pedro, GDB maintainers: > > This patch fixes the reverse-finish command on PowerPC. The command > now works the same as on other architectures, specifically X86. There > are no functional changes for other architectures. The patch includes > a new testcase to verify the reverse-finish command works correctly > with the multiple entry points supported by PowerPC. > > > Patch tested on PowerPC and 5th generation X86 with no regression > failures. > > Carl Hi Carl, I don't know if that particular failure has been reported yet, but I see these failures when running with native-gdbserver or native-extended-gdbserver: $ make check TESTS="gdb.reverse/finish-reverse-next.exp" RUNTESTFLAGS="--target_board=native-gdbserver" FAIL: gdb.reverse/finish-reverse-next.exp: reverse-finish function1 LEP call from LEP FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 LEP entry point function call from LEP FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2, at b = 5, call from LEP FAIL: gdb.reverse/finish-reverse-next.exp: reverse-finish function1 LEP call from function body FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 LEP from function body FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2 at b = 5, from function body FAIL: gdb.reverse/finish-reverse-next.exp: function1 GEP call call from GEP FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 GEP entry point function call from GEP FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2 at b = 50, call from GEP FAIL: gdb.reverse/finish-reverse-next.exp: function1 GEP call call from GEP again FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 GEP entry point function call from GEP again FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2 at b = 50, call from GEP again FAIL: gdb.reverse/finish-reverse-next.exp: reverse-finish function1 GEP call, from function body FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 GEP call from function body FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2 at b = 50 from function body Simon