Re: [PATCH][PR gdb/8527] Interrupt not functional in Eclipse/CDT on Solaris

[Simon Marchi <simon.marchi@ericsson.com>]

On 2018-11-01 5:45 p.m., Brian Vandenberg wrote:
> Greetings,
> 
> Did you run the testsuite before and after the patch, by any chance?
> 
> 
> Nope.  In my work environment I don't have much flexibility on
> getting/installing software.  If I run the test suite I would probably have
> to setup an IllumOS VM at home to run it, but that'd be x86 not SPARC.
> 
> 
> For multiline comments like the above, we do not repeat the '*'
>> at the beginning of each line.
>>        /* PR gdb/8527: Was not correctly interrupting the inferior process
>>           when ^C was pressed in the debug terminal.  */
>> And if I may, reading this sentence, it's a bit hard to understand
>> what the comment is trying to explain. The following might be
>> a little more precise:
>>        /* PR gdb/8527: Call set_sigint_trap to make sure that a ctrl-c
>>           pressed in the debugger terminal gets passed down to the
>>           inferior, thus causing it to be interrupted.  */
> 
> 
> I've no qualms with those changes.  Thanks for your feedback.

Asking because it's ambiguous... do you plan on sending an updated patch?

As for the patch content and its testing, perhaps Rainer can give some feedback.

Simon