public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Sandra Loosemore <sandra@codesourcery.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFC] fix thread.c assertion after stepping past end of program
Date: Tue, 30 Apr 2019 15:33:00 -0000	[thread overview]
Message-ID: <5e7031b1-8faa-4951-03eb-94c59bc5f615@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

We've run into an assertion failure when quitting GDB after stepping 
past the end of a program that was linked with stripped libraries. 
Here's how it's triggered, using a simple factorial example for 
nios2-linux-gnu target with gdbserver:

Breakpoint 1, main () at /home/sandra/examples/fact.c:13
13        for (i = 0; i < 10; ++i) {
(gdb) advance 17
main () at /home/sandra/examples/fact.c:17
17        return 0;
(gdb) s
18      }
(gdb) s
0x2aaefffc in __libc_start_main ()
    from 
/./scratch/sandra/nios2-linux-spring-release/install/opt/codesourcery/nios2-linux-gnu/libc//lib/libc.so.6
(gdb) s
Single stepping until exit from function __libc_start_main,
which has no line number information.
[Inferior 1 (process 15772) exited normally]
You can't do that without a process to debug.
(gdb) s
The program is not being run.
(gdb) quit
/scratch/sandra/nios2-linux-fsf/obj/gdb-src-mainline-0-nios2-linux-gnu-x86_64-linux-gnu/gdb/inferior.c:287: 
internal-error: inferior* find_inferior_pid(int): Assertion `pid != 0' 
failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n)

The attached 1-liner patch fixes it and didn't cause regressions 
elsewhere.  However, I'm not sure if this is really where the bug is. 
Maybe some other state is not getting cleaned out when the inferior 
exits?  WDYT?

-Sandra

[-- Attachment #2: thread.patch --]
[-- Type: text/x-patch, Size: 483 bytes --]

diff --git a/gdb/thread.c b/gdb/thread.c
index 91741c7..c44b2b0 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -628,8 +628,8 @@ any_thread_of_inferior (inferior *inf)
 {
   gdb_assert (inf->pid != 0);
 
-  /* Prefer the current thread.  */
-  if (inf == current_inferior ())
+  /* Prefer the current thread, if there is one.  */
+  if (inf == current_inferior () && inferior_ptid != null_ptid)
     return inferior_thread ();
 
   for (thread_info *tp : inf->non_exited_threads ())

             reply	other threads:[~2019-04-30 15:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 15:33 Sandra Loosemore [this message]
2019-04-30 21:15 ` Sandra Loosemore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e7031b1-8faa-4951-03eb-94c59bc5f615@codesourcery.com \
    --to=sandra@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).