From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 13F193857028 for ; Mon, 17 Apr 2023 18:21:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13F193857028 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BFE061E0D5; Mon, 17 Apr 2023 14:21:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1681755685; bh=hz7JKwRiHbHE8FEHfWcPKslYiOHcUjKceEDAOPG6xc0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=B7WYsJj+qj+kj4DvocAnK1Vi5H9MdxZ5/wLBNBZDe85jIaWPS1clGeaWVHk2RKDAB WWlvZv+qc7Ij1uHKvDEh9c3RD6ojBnAXWGl2P8ksSdcIqGQru82HRhJT8orh9Ce/Vh CMIRotV2bvuWhSMQwa4KvY2NVX+MfDXwpNigk3h0= Message-ID: <5eab0407-31ba-ffd4-237d-81882f8e3a28@simark.ca> Date: Mon, 17 Apr 2023 14:21:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 0/5] Fixes for per-inferior settings and $_gdb_setting_str() Content-Language: fr To: Andrew Burgess , gdb-patches@sourceware.org References: <636ce26d-19e9-124e-5323-8362a9928bcd@simark.ca> From: Simon Marchi In-Reply-To: <636ce26d-19e9-124e-5323-8362a9928bcd@simark.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/17/23 14:09, Simon Marchi via Gdb-patches wrote: > On 4/4/23 08:45, Andrew Burgess via Gdb-patches wrote: >> While working on another patch I spotted that >> $_gdb_setting_str("args") wasn't working correctly. Turns out args, >> cwd, and inferior-tty all have the same problems. This series >> resolves these issues. > > That rang a bell, it's because I have fixed some of these downstream in > ROCgdb, and haven't sent it upstream yet. The downstream commit is > here: > > https://github.com/ROCm-Developer-Tools/ROCgdb/commit/54d0a79614071fd62df5e2dfe793ff26cc7e31e6 > > I'll take a look at your patches, I presume that they will do mostly the > same thing. And if my patch does more (according to the commit message, > it fixes "remote exec-file" and "tdesc filename"), I can send what > remains after. So, my patch adds some tests for gdb.parameter (Python), MI and the with command. However, they are sprinkled in different files. I like that you have a test file specifically to exercise the settings that are per-inferior. Your test could probably be augmented to exercise all these ways to get a setting. You series looks good to me, up to you if you want to merge it as-is or improve it based on what I had. Simon