From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8988A3857809 for ; Wed, 23 Mar 2022 16:02:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8988A3857809 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-533-_9AgWH4wNJabucTAsT1JBg-1; Wed, 23 Mar 2022 12:02:49 -0400 X-MC-Unique: _9AgWH4wNJabucTAsT1JBg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF58985A5BC for ; Wed, 23 Mar 2022 16:02:48 +0000 (UTC) Received: from [10.2.17.71] (unknown [10.2.17.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5705F7ADF; Wed, 23 Mar 2022 16:02:48 +0000 (UTC) Message-ID: <5ed305d0-3650-a9f9-e128-22f873cd96a0@redhat.com> Date: Wed, 23 Mar 2022 09:02:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] Remove download size from debuginfod progress messages To: Aaron Merey , gdb-patches@sourceware.org References: <20220323003432.123142-1-amerey@redhat.com> From: Keith Seitz In-Reply-To: <20220323003432.123142-1-amerey@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2022 16:02:51 -0000 On 3/22/22 17:34, Aaron Merey wrote: > Currently debuginfod progress update messages include the size of > each download: > > Downloading 7.5 MB separate debug info /lib/libxyz.so.0 > > This value originates from the Content-Length HTTP header of the > transfer. However this header is not guaranteed to be present for > each download. This can happen when debuginfod servers compress files > on-the-fly at the time of transfer. In this case gdb wrongly prints > "-0.00 MB" as the size. I realize this is an interim patch to address an issue currently under development, and I'm okay with that. There are a lot of people that use devel versions of gdb to do work. [At least I hope I'm not alone!] However, I would really rather not simply remove all download sizes. If we can detect the condition that would print the unhelpful "-0.00 MB", then *just* removing the download size for that case (or printing "unknown" or something) would be my preferred path. YMMV, and I am not a maintainer, etc. Keith