From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 20DA53858D20 for ; Wed, 17 Apr 2024 09:48:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 20DA53858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 20DA53858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713347312; cv=none; b=BO9fVrqrqZl2XQTERRaS56NrqJ27/L3U0SAw+sO0A2sKC1e3IKebOa5PWu+RCvKBGqMnfUwmGycSp3vjqzm33OcGCKFY+N4puK5CaUumg546VzhRGoP/5fcAsyySooF462xwMODdHB5B1CSmCRh+IKihMDm+wrxTKXlgYsaZxUY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713347312; c=relaxed/simple; bh=0xayzZzcOVG0NtA8YE+WFLFeR5QqrifjC/ZRRp/Bn3g=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=Xvwi7Xu1P9hN6q0DkhCvur8QKAz+5cbQLLKvwYXEbuWtXQorIXd59GoZ4ojavFibcjWJt/RvoAEPRDj7uMxuCRV3aEbQlex3lJD7cm6E8pLN3s9cXFxESZM/+zgkb5cso11krr6WqWsHPko+z0MBAYLFXS4Mi7nceatgQWmWCEI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1C96D20681; Wed, 17 Apr 2024 09:48:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713347309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gqCQHV1EN7iWUigGdj4pe0bjrPZ4p596xfodDgQjS9s=; b=BwIrvuJGpC/LUktajFEb1xv1gOvX3Bg27ce6Aycyi33vbO8Hw7WhuMM9tM0rOm7PFidQuX SRbDAho5B0rfXPZqHI+aYA1+eKoceetkcfrXKVuGUawsMifFYzZjusQ+ZREKzfc4w4BtIs 2+3cbTYIGJ9FDuhNWf9qHYAyb7t58/Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713347309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gqCQHV1EN7iWUigGdj4pe0bjrPZ4p596xfodDgQjS9s=; b=Lhg9Tg6vFukZ7O4tHE5UKM9ettKe7mdVLd8VfWSdbON08AgvfCJL5gWrgzHtG/u8KpeBmO NGCKm5LD/EapXiCQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=BwIrvuJG; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Lhg9Tg6v DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713347309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gqCQHV1EN7iWUigGdj4pe0bjrPZ4p596xfodDgQjS9s=; b=BwIrvuJGpC/LUktajFEb1xv1gOvX3Bg27ce6Aycyi33vbO8Hw7WhuMM9tM0rOm7PFidQuX SRbDAho5B0rfXPZqHI+aYA1+eKoceetkcfrXKVuGUawsMifFYzZjusQ+ZREKzfc4w4BtIs 2+3cbTYIGJ9FDuhNWf9qHYAyb7t58/Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713347309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gqCQHV1EN7iWUigGdj4pe0bjrPZ4p596xfodDgQjS9s=; b=Lhg9Tg6vFukZ7O4tHE5UKM9ettKe7mdVLd8VfWSdbON08AgvfCJL5gWrgzHtG/u8KpeBmO NGCKm5LD/EapXiCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 028A413976; Wed, 17 Apr 2024 09:48:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HxGrOuyaH2bMXwAAD6G6ig (envelope-from ); Wed, 17 Apr 2024 09:48:28 +0000 Message-ID: <5ee0788d-44e2-456b-a691-7dbe6e82a8a2@suse.de> Date: Wed, 17 Apr 2024 11:48:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] [gdb/testsuite] Simplify gdb.server/server-kill-python.exp To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240412175101.9154-1-tdevries@suse.de> <87il0h1awx.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87il0h1awx.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.29 X-Rspamd-Action: no action X-Rspamd-Queue-Id: 1C96D20681 X-Spam-Level: X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.29 / 50.00]; BAYES_HAM(-1.79)[93.73%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:email]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/16/24 19:21, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> # Now start GDB, sourcing the python command file we generated above. > Tom> # Set the height and width so we don't end up at a paging prompt. > Tom> if {[gdb_spawn_with_cmdline_opts \ > Tom> - "-quiet -iex \"set height 0\" -iex \"set width 0\" -ex \"source $host_file1\""] != 0} { > Tom> + "-quiet -iex \"set height 0\" -iex \"set width 0\""] != 0} { > Tom> fail "spawn" > Tom> return > > Do this even need any arguments now? I thought the default was to set > width and height to 0. Indeed that's not needed. I've committed this in the current, "minimal change" form, and I'll write a patch cleaning up the issue you raised here in general. Thanks, - Tom