public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/8] [gdb/testsuite] Speed up MACRO_AT_* calls
Date: Mon, 22 Nov 2021 09:17:48 +0100	[thread overview]
Message-ID: <5ef89534-ba0f-142b-0f80-f97db3ed3087@suse.de> (raw)
In-Reply-To: <20211025103000.1237-2-tdevries@suse.de>

On 10/25/21 12:29 PM, Tom de Vries via Gdb-patches wrote:
> Currently, for each MACRO_AT_range or MACRO_AT_func in dwarf assembly the
> following is done:
> - $srcdir/$subdir/$srcfile is compiled to an executable using
>   flags "debug"
> - a new gdb instance is started
> - the new executable is loaded.
> 
> This is inefficient, because the executable is identical within the same
> Dwarf::assemble call.
> 
> Share the gdb instance in the same Dwarf::assemble invocation, which speeds
> up a make check with RUNTESTFLAGS like this to catch all dwarf assembly
> test-cases:
> ...
> rtf=$(echo $(cd src/gdb/testsuite; find gdb.* -type f -name "*.exp" \
>       | xargs grep -l Dwarf::assemble))
> ...
> from:
> ...
> real    1m39.916s
> user    1m25.668s
> sys     0m21.377s
> ...
> to:
> ...
> real    1m29.512s
> user    1m17.316s
> sys     0m19.100s
> ...
> 

I've rewritten this patch to not use the finally proc introduced in 1/8,
and pushed the series starting this patch.

Thanks,
- Tom


  reply	other threads:[~2021-11-22  8:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 10:29 [PATCH 1/8] [gdb/testsuite] Factor out proc finally Tom de Vries
2021-10-25 10:29 ` [PATCH 2/8] [gdb/testsuite] Speed up MACRO_AT_* calls Tom de Vries
2021-11-22  8:17   ` Tom de Vries [this message]
2021-10-25 10:29 ` [PATCH 3/8] [gdb/testsuite] Add test-case gdb.dwarf2/dw2-lines.exp Tom de Vries
2021-10-25 10:29 ` [PATCH 4/8] [gdb/testsuite] Support .debug_line v4 in dwarf assembler Tom de Vries
2021-10-25 10:29 ` [PATCH 5/8] [gdb/testsuite] Factor out_line_finalize_header Tom de Vries
2021-10-25 10:29 ` [PATCH 6/8] [gdb/testsuite] Support .debug_line v5 in dwarf assembler Tom de Vries
2021-10-25 10:29 ` [PATCH 7/8] [gdb/testsuite] Add target board dwarf64.exp Tom de Vries
2021-10-25 10:30 ` [PATCH 8/8] [gdb/symtab] Support .debug_line with DW_FORM_line_strp Tom de Vries
2021-11-19 15:06 ` [PING][PATCH 1/8] [gdb/testsuite] Factor out proc finally Tom de Vries
2021-11-19 19:33 ` [PATCH " Pedro Alves
2021-11-19 20:53   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ef89534-ba0f-142b-0f80-f97db3ed3087@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).