From: Simon Marchi <simon.marchi@polymtl.ca>
To: Bruno Larsen <blarsen@redhat.com>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH v3 7/7] gdb/testsuite: add macros test for source files compiled in various ways
Date: Thu, 28 Jul 2022 13:51:44 -0400 [thread overview]
Message-ID: <5f002cdf-2afb-8e4b-814e-2db90452b224@polymtl.ca> (raw)
In-Reply-To: <064ba095-12d1-8b27-47c4-50e34fcc3b99@redhat.com>
>> +# Based on `gcc -gdwarf-5 -g3 <file>`, gcc 11 paired with gas from binutils 2.38.
>
> This comment wasn't really clear to me. Maybe something like "The
> following calls are based on ..." or something to make clear that this
> comment refers to a group of do_test calls below, would avoid possible
> confusion.
Done. I changed them to "The following tests are based on the output
of...".
Thanks,
Simon
next prev parent reply other threads:[~2022-07-28 17:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 3:35 [PATCH v3 0/7] Fix printing macros Simon Marchi
2022-04-28 3:35 ` [PATCH v3 1/7] gdb: introduce symtab_create_debug_printf Simon Marchi
2022-04-28 15:49 ` Tom Tromey
2022-04-28 3:35 ` [PATCH v3 2/7] gdb: add debug prints in buildsym.c Simon Marchi
2022-04-28 15:50 ` Tom Tromey
2022-04-28 3:35 ` [PATCH v3 3/7] gdb/dwarf: pass compilation directory to line header Simon Marchi
2022-04-28 15:48 ` Tom Tromey
2022-04-28 15:59 ` Simon Marchi
2022-04-28 3:35 ` [PATCH v3 4/7] gdb/dwarf: pass a file_entry to line_header::file_file_name Simon Marchi
2022-05-03 20:12 ` Bruno Larsen
2022-07-28 16:26 ` Simon Marchi
2022-04-28 3:35 ` [PATCH v3 5/7] gdb: add "id" fields to identify symtabs and subfiles Simon Marchi
2022-04-28 23:53 ` Lancelot SIX
2022-07-28 17:46 ` Simon Marchi
2022-04-28 3:35 ` [PATCH v3 6/7] gdb: remove code to prepend comp dir in buildsym_compunit::start_subfile Simon Marchi
2022-05-12 13:07 ` Bruno Larsen
2022-07-28 17:47 ` Simon Marchi
2022-04-28 3:35 ` [PATCH v3 7/7] gdb/testsuite: add macros test for source files compiled in various ways Simon Marchi
2022-05-12 13:17 ` Bruno Larsen
2022-07-28 17:51 ` Simon Marchi [this message]
2022-07-30 0:56 ` [PATCH v3 0/7] Fix printing macros Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f002cdf-2afb-8e4b-814e-2db90452b224@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).