From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 49C913858D33 for ; Wed, 25 Jan 2023 17:03:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 49C913858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 30PH37Ps028862 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 25 Jan 2023 12:03:12 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 30PH37Ps028862 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1674666192; bh=YjT0hh7ZdeiB6Ij80HsBQ37teLULj5BHsHFI0Wg7Uns=; h=Date:Subject:To:References:From:In-Reply-To:From; b=KjqGq5Hyr3tt5NklWIgPsB8LlwVTbsAXYxeZVX0dPV+sckHbj17oQNIkm3a4lW4ZE DMoaJCKPnq6KJACDQ01MgA+ZZspGotZkMxq2FeUx7Qf13ha/Kl0JDK51LKDoVTygKf ZWcBIzy1mQR+rAuQBZ9LNBb8YWUy1gP5HrlvRAX4= Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BABC31E110 for ; Wed, 25 Jan 2023 12:03:07 -0500 (EST) Message-ID: <5f28702a-53a9-1e8c-88d2-85e020e3b3f2@polymtl.ca> Date: Wed, 25 Jan 2023 12:03:07 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 0/8] Initial support for ROCm platform (AMD GPU) debugging Content-Language: en-US To: gdb-patches@sourceware.org References: <20230105200237.987771-1-simon.marchi@polymtl.ca> From: Simon Marchi In-Reply-To: <20230105200237.987771-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 25 Jan 2023 17:03:07 +0000 X-Spam-Status: No, score=-3032.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/5/23 15:02, Simon Marchi wrote: > This is the v2 of: > > https://inbox.sourceware.org/gdb-patches/20221206135729.3937767-1-simon.marchi@efficios.com/ > > I pushed patches 5, 7, 8 and 9, since I considered them good chances even > outside of this series. > > Most other preparatory patches have been reviewed and LGTM'ed by Andrew > Burgess, but they are not really useful on their own, so they are still > in this series. There are no changes in them, except a typo fix in > patch 3. > > The only preparatory patch which was not reviewed is "gdb/solib-svr4: > don't disable probes interface if probe not found". Ping. I plan to push the series in a week from now, if there are no more comments on this. Note that this code has been heavily scrutinized by Pedro and Lancelot, so I am confident that it is in good shape already. Simon