From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] gdb/testsuite: gdb.base/args.exp: add KFAIL for native-extended-gdbserver
Date: Thu, 17 Jun 2021 11:35:54 +0100 [thread overview]
Message-ID: <5f3f963f-8788-f2a0-be8f-e172b0f9f945@palves.net> (raw)
In-Reply-To: <20210616193751.468795-4-simon.marchi@efficios.com>
On 2021-06-16 8:37 p.m., Simon Marchi via Gdb-patches wrote:
> + # Start GDB just to see if we are using the native or extended-remote target.
> + clean_restart
> + set single_quotes_newline_kfail [gdb_is_target_remote]
> +
You don't need to do that. You can check
if {[target_info exists gdb_protocol]
&& ([target_info gdb_protocol] == "remote"
|| [target_info gdb_protocol] == "extended-remote")} {
The series looks good to me.
Pedro Alves
next prev parent reply other threads:[~2021-06-17 10:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 19:37 [PATCH 1/4] gdb/testsuite: gdb.base/args.exp: use save_vars Simon Marchi
2021-06-16 19:37 ` [PATCH 2/4] gdb/testsuite: gdb.base/args.exp: use $old_gdbflags last two tests Simon Marchi
2021-06-16 19:37 ` [PATCH 3/4] gdb/testsuite: gdb.base/args.exp: remove trailing parenthesis in test names Simon Marchi
2021-06-16 19:37 ` [PATCH 4/4] gdb/testsuite: gdb.base/args.exp: add KFAIL for native-extended-gdbserver Simon Marchi
2021-06-17 10:35 ` Pedro Alves [this message]
2021-06-17 13:41 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f3f963f-8788-f2a0-be8f-e172b0f9f945@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).