From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60072.outbound.protection.outlook.com [40.107.6.72]) by sourceware.org (Postfix) with ESMTPS id 168B838133E9 for ; Mon, 30 May 2022 09:02:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 168B838133E9 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iHbbbZM6/RzmZ1AFz3S8AHycEBOBaaOpOnIg7jZy/cFtkUBGB/+FO85y1MrEsfedEvsZBEKhcqUwfi3iG3O9bC38cyoUzFUJK0MBOX9MfCRjnh0BAksfAqU0NhflYujkJC3HtID+bl+Dsb/DmbYSLbAv6d1D8gG1kYdPjr2h2px3qeyJhPSA8X7l6/b12+SLugTjS848u4mtAPuhPZe7u3nPm39kOb9XrdmwMPXhGBkRxRrxDTh/GUCVJEpLagjI1ZpY770F1eBT4oARyh7R4FVL9n1W0s+fcs4yYDSB1M8KPz9U9fTkFhVF8E+ubf6jmUPznGUBbmZou8tW8ufbfA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mb0QkIRJSmdFaQPeMECKwH2QkfygLxSIYFN+j3ym2HM=; b=mNNDYRQOS1CmC6GLnTnfxD1L46dk3P1f6nkdI8TvUYCfxZcPIFxEHweOlB5rir0wH0nBUDrhcXtscxlymC2LVyKuNQanouAgTv+H3kEmjKmB5XEmLbNKzIj7Kpo0OASEKfAEshQ87KPsFikZ6DSrjh/RHWOA2FeMzrq9tM3ADNv911WRirFRyZ7Y1xp2QHwk+St1OBVOsueGvCQVVVsBA5T3Irx7/yNbQFGhlO63wN3mmf0ftVO7ic6egoJWZO6nNQ2yC06L9Y+UF2QSePMjEE+8d0kaVbltHr3VuIHSYT6APayr6JOwSAYeHjVHx9ad3aoyTXr0LAemxwBRg3HZ3g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS9PR06CA0094.eurprd06.prod.outlook.com (2603:10a6:20b:465::7) by AM0PR08MB5380.eurprd08.prod.outlook.com (2603:10a6:208:183::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Mon, 30 May 2022 09:02:06 +0000 Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:465:cafe::29) by AS9PR06CA0094.outlook.office365.com (2603:10a6:20b:465::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Mon, 30 May 2022 09:02:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Mon, 30 May 2022 09:02:05 +0000 Received: ("Tessian outbound 07c1c99345b0:v119"); Mon, 30 May 2022 09:02:05 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c167aa1bc4222ae5 X-CR-MTA-TID: 64aa7808 Received: from 835fbf06ab47.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 005D37BF-BC9F-4843-BAA4-261A775F8160.1; Mon, 30 May 2022 09:01:58 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 835fbf06ab47.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 30 May 2022 09:01:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VnqTZNNPHIDIpsztlSU5jr2XBTaYwdiqC26p/HSHtxX8Kho9ksqhEbUMb8jUrBV2eLFoBmHd3mjbzElDdouLfeGqJH2vgvTh026y+K+MC6N9ysP7pImTxfvq19fZStwCsnmNQMDnAImaWRBGZxWMGnOm7b/rBmEGKiN8ABUWi4k7G1v9vrQspRcq2aosg8s5b1WmimsnwudPPPpKlZAZsMjifpLaviVkWohJg5i/slXJTdgNahtSlEHgeHkA77n1mP8R7mdNF3nbS4EWbPjgmdeA7f063dtFhQ3r262zcEzL12KsnQ6GoSBC/kYDXOOu4aK1TRLmqKBNZY0gUdSOjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mb0QkIRJSmdFaQPeMECKwH2QkfygLxSIYFN+j3ym2HM=; b=YqZ1cPcHSaVPcG9WQJ6M9LWiR6XkiN5U6kI3cWPngUFiMwK7C47SzdMdwbQhZ+fee8+kr/V3qZx0J77CnzOzglCcT+xXrXno0IlzrHx0ygkJ7dSbdF6WhGT1Iw0G5gCBPE5WYxTLHtC1Qvt2cJZwPZ0kg0saLe8G66QWbeZI5U+d7qfPTOxeFzSsVf5UEGZTnQnCy0StJ+YmQfZiHdY7sB76Tfq5mESvV0d9QyoBlbsbIutD2WB2PSSGOEfKfJvAF7/BbG8arvA0TDjDN1l997i5gKLzWhgJ8IZpE0hiQSMW4CKHu8Ol7XyWaIcEmTwk+IYJnj4MlMoSm8BX76xVbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3694.eurprd08.prod.outlook.com (2603:10a6:803:b6::26) by AM0PR08MB3938.eurprd08.prod.outlook.com (2603:10a6:208:123::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.16; Mon, 30 May 2022 09:01:55 +0000 Received: from VI1PR08MB3694.eurprd08.prod.outlook.com ([fe80::1916:206:dd8b:6a91]) by VI1PR08MB3694.eurprd08.prod.outlook.com ([fe80::1916:206:dd8b:6a91%4]) with mapi id 15.20.5293.019; Mon, 30 May 2022 09:01:55 +0000 Message-ID: <5f49df79-7ef5-f945-4eaa-1b8ce2ba987c@arm.com> Date: Mon, 30 May 2022 11:01:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] gdb/arm: d0..d15 are 64-bit each, not 32-bit Content-Language: en-US To: Yvan Roux , gdb-patches@sourceware.org Cc: Torbjorn SVENSSON References: <20220525151407.GB11828@gnbcxd0114.gnb.st.com> From: Christophe Lyon In-Reply-To: <20220525151407.GB11828@gnbcxd0114.gnb.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0029.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::16) To VI1PR08MB3694.eurprd08.prod.outlook.com (2603:10a6:803:b6::26) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: a6d60851-2ebd-4022-9a69-08da421b11ff X-MS-TrafficTypeDiagnostic: AM0PR08MB3938:EE_|VE1EUR03FT055:EE_|AM0PR08MB5380:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XkHxSb1ZgvyrVVy24L/5rF/F/aVR/3sSsRUhS+IhMqqo9ixHsF3xfDL5bqToy7KdxzSJdlYFJ71m1xuT7nQsm2IMgP3qmU/hJaBzt2vxqRXgIK4+5cv4J7YPVJdhDPRyb34+Cnq5XBBQLsVenI4/FpLrRXtQmfC+MtfRlL2ODKuzSdjd1AZJIp48QNY0RL+bOLO7CougJjM8k27QGrzdCVxmu3kb3lK2qpzKGaVSlIP229rGG+SyQ1NwoBKwq2j5bu61ITzvtkT2g+idNYtbbCXYtDO+WwV0KSyYuMwhuO0K09Md38MXeW15a7NaPX9iYuYEFdwdZ9Qv6XfLoNhJX+DHoV/r9Tar7pNcnc377uG7w3yHZ60sSo7hYycm5nqNXBhOIM8mVfV+xPGaf3OYMz3kjuF9s7KdPJVwitcD2un1XeJNaR0gz5RJa/jJlsKPDvp9r36fEFCIlT3UI364/ememWzFPZlDM1Aj5+6fwdKK8Lbm+S06Y44p9+gzlrzwbavKdVkjvRtsLvDCtAQqVeiy5V3qlwhGkSpDo1mo/rwiSnOBQ7NyRP7tgfbz1y4ajNYkmM/z6a7w11EeNT6IZQUvZ6O04Jj3kFas61mVY4t3cQv8j3xoCy9zjrZYn0YXqgrkmTWAKFSqNEUhDlnHaxUUfvLk6UHSsK/dL83aQ+4z0H2ZoiyPn/pf9/TFNaqqUjIyjoMudbOftu0Gk6TFvyOfjfahmTKDtDyDkr/cd2vTQue5NYPSILEz8IkZfcNGcdlD8FFOsW9JiZRW09gezA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3694.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(36756003)(66946007)(2906002)(66476007)(316002)(44832011)(31686004)(4326008)(8676002)(66556008)(5660300002)(83380400001)(2616005)(53546011)(6512007)(6506007)(508600001)(26005)(186003)(86362001)(6486002)(31696002)(8936002)(38100700002)(101420200003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3938 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: be78fbd9-d0a0-4241-6a08-08da421b0b74 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Rr2G6yW0h4/nKCcqRvIEYANxQBFKNvTEZVUIxe3h/y/heMeQZ2OEMiBORfX6DUsW/Awla+dfVExWdgV/6sU+gsYZw4gQbaD4Vhn1jIBi4smdHUEjpSnr96WKrhg3Y3ouQxqYrFeICkEcRNKbzCQlr/KyAQVQOhQCI0dX0YHUhF60Yy6cxcKSRyGx+R3/dcmDfT6fegloz5se29rtoZ5H9Pg7DZbUyvecTSB/B/NHZmpbDacdw+Rb+vMA3czYvV/ZBzkTvgkMgtMG7DB/nzG7q9gHQmigtnsNXDrXh7/8lVDe56gWUmA3HGk4L8fcakcwMsx8HFikqC+EEfeCAsCWvPZGYuEcEZQiuLHSXhaqLhnhVwKzbT+two50cf3wqAvDVflH9uHlm17ZyrMbfVyk/UplT3lBQj8F5S5tuRqBY3LuLT1BPqD+6MWejg1+mOLfb5rPG/skq1c+A6j1YlQjaWI0/4EqEc/vTkmc7YyZuUmpbhIv5/mGGiEhLISwE2c+KbuBu8/X0bHhSTPXgQmCi3vS5EqVTeTx2ENDtL5BJWAfTE9B7o8XqohLTT6FN/AfjmWBGAGCVJDwuUIoZ766Efr05q5sVBHbo7weueF0dOgEWSvbbiTKHP721jZNIK09/2xhRbKpLvVpCP5TasEVzAjW0LvumAMqC5Pu584RsMnaoNbcD9VwVg/eV6b+oCWNPLnodKMmSUExlYyqRMFLgZkzFzA+K0Gplzk/JIYYpJTuYKf07DobHEYjNHYU+Q0u X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(5660300002)(31686004)(186003)(336012)(2616005)(31696002)(6486002)(508600001)(82310400005)(44832011)(81166007)(47076005)(36860700001)(86362001)(83380400001)(70586007)(36756003)(4326008)(70206006)(6506007)(8676002)(53546011)(316002)(8936002)(2906002)(356005)(26005)(40460700003)(6512007)(101420200003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 09:02:05.8797 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a6d60851-2ebd-4022-9a69-08da421b11ff X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5380 X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 May 2022 09:02:12 -0000 On 5/25/22 17:14, Yvan Roux via Gdb-patches wrote: > Hi, > > When unwinding the stack, the floating point registers d0 to d15 > needs to be handled as double words, not words. > > Only the first 8 registers has been confirmed fixed with this patch > on a STM32F407-DISC0 board, but the upper 8 registers on Cortex-M33 > should be handled in the same way. > > The test consisted of running a program compiled with float-abi=hard. > In the main function, a function took a double as an argument was > called. After the function call, a hardware timer was used to > trigger an interrupt. > In the debug session, a breakpoint was set in the function called > from main to verify the content of the registers using "info float" > and another breakpoint in the interrupt handler was used to check > the same registers using "info float" on frame 2 (the frame just > before the dummy frame created for the signal handler in gdb). I guess that's because 'info float' shows these registers as double-precision, and the confusion comes from the fact that the Arm v8-M ARM describes this stack frame in terms of single-precision registers (S0..S15, then S16..S32)? > > Signed-off-by: Torbj�rn SVENSSON > Signed-off-by: Yvan Roux > --- > gdb/arm-tdep.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index 49664093f00..6c0aca274f5 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -3464,10 +3464,10 @@ arm_m_exception_cache (struct frame_info *this_frame) > > /* Extended stack frame type used. */ > fpu_regs_stack_offset = unwound_sp + sp_r0_offset + 0x20; > - for (i = 0; i < 16; i++) > + for (i = 0; i < 8; i++) > { > cache->saved_regs[ARM_D0_REGNUM + i].set_addr (fpu_regs_stack_offset); > - fpu_regs_stack_offset += 4; > + fpu_regs_stack_offset += 8; > } > cache->saved_regs[ARM_FPSCR_REGNUM].set_addr (unwound_sp + sp_r0_offset + 0x60); > fpu_regs_stack_offset += 4; > @@ -3476,10 +3476,10 @@ arm_m_exception_cache (struct frame_info *this_frame) > { > /* Handle floating-point callee saved registers. */ > fpu_regs_stack_offset = 0x90; > - for (i = 16; i < 32; i++) > + for (i = 8; i < 16; i++) > { > cache->saved_regs[ARM_D0_REGNUM + i].set_addr (fpu_regs_stack_offset); > - fpu_regs_stack_offset += 4; > + fpu_regs_stack_offset += 8; > } > > arm_cache_set_active_sp_value (cache, tdep, unwound_sp + sp_r0_offset + 0xD0);