From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 6795D385843E for ; Tue, 2 May 2023 15:40:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6795D385843E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 90F48215EF; Tue, 2 May 2023 15:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683042032; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fLOQ4cy3ETRdo1zd6Q1boYmUYpdijWqv8JttU/TosPM=; b=0MrmfkOTMFBT6JD2R1OREgInZ+BEdr/eWp4X4r7sLhq7FlveD/bdlTV12IE0YVm9v3liiK 5wPslE9Eqq00qtzzGsshHw7tyS8pe4Go+k54jsed6TofxliZEWqKIrgc7IwFAxCDilHXQt mTdVb68WfHaiAjK8dEh2xqOyRhHY6Q4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683042032; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fLOQ4cy3ETRdo1zd6Q1boYmUYpdijWqv8JttU/TosPM=; b=ct4Yjq6qYwo4q42OwPkFvRh4DmpYjJUYj1Td4yBAAAauelk8YnJdQtj+wg5jnkG+2v8i/5 qVWQ+cPz1SoClIAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7E14E134FB; Tue, 2 May 2023 15:40:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +3jFHfAuUWT5JwAAMHmgww (envelope-from ); Tue, 02 May 2023 15:40:32 +0000 Message-ID: <5f4f5d69-311c-e97b-5d40-4a8ffbd57b7d@suse.de> Date: Tue, 2 May 2023 17:40:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [pushed 1/4] [gdb/testsuite] Don't use string cat in gdb.dwarf2/dw2-abs-hi-pc.exp Content-Language: en-US To: Tom Tromey , Tom de Vries via Gdb-patches References: <20230424124846.29580-1-tdevries@suse.de> <874jp5z0n8.fsf@tromey.com> <2a3587b4-98c4-263a-7deb-9530fbf06c57@suse.de> <878refyfgn.fsf@tromey.com> <97d43c1a-45d2-6ec5-001f-e20709342ce3@suse.de> <87354lxx4p.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87354lxx4p.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/27/23 15:39, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries via Gdb-patches writes: > > Tom> Then with subst we have the same: > Tom> ... > Tom> set res [lmap v $l { subst {$v/c} }] > Tom> ... > Tom> unless we forget the quoting: > > This is true for everything in Tcl though. > The quoting matters a lot. > True. > Tom> Hmm, in that case I think subst is the worse choice. With expr, > Tom> things either parse or not, and if it parses you get the right result. > > expr has corner cases where weird things will happen as well. > It's really just intended for use with the expression sub-language. Ack. I've just pushed a patch that uses set instead of expr, so this is no longer an issue. Thanks for reporting this. - Tom