From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B81B7384AB58 for ; Fri, 3 May 2024 13:21:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B81B7384AB58 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B81B7384AB58 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714742474; cv=none; b=gciAGt8D9pvbJCIHgfesPlLHJIxbaiQtxY+RdxHAfetTHrUr17hFb6fnsPlBXxFgXsRPQhURX+8eD6MsZfRb4e/4LzT0LZu0vJ/xrMB4wVE6HEt4J84CKhvsuvI9+sPA5/7YWWEdU/Hf63SZ/VyUDqikGE2h/JTO4Z6wH2kBzSM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714742474; c=relaxed/simple; bh=VfoUo0LrzL0CJh6tN5BRKKdLCYBAlnEZ467gmXuYRFI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=DoEGfJpPWCr9/YM4dLIZWYw0SVAtI0CIzLJ6ZtYRBFWbp64sTABfy9b5V7fY+x9ruYJvIgY4NmH+r44PPbkLm5jKQuQlyrSHABmNhxWI5PLI2MeXOEBvnu25P4pljzaWQPXR6pu+3VWcXIbAZjCiNkMNTSIaV8ZXWJbqGVOguq4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714742472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kmo/rwZQd1lyus2Gkzo8TDtz4e4HkdDRoxbRfV4mTfg=; b=NU3JSuwGY4wRB4TBFRVPQm+fLqbDWaeotfIeBda3KNk+EClf1R1WBMDSHykNGYBTyWRJLn OSYruuIkYl5KedCNMFybQ6Qvuahv9blYIxybTBUMcj4EMSEAPf+MAw4Ie1loIz5jU/tbxI iPJGKLqpXFUr4gc1jFVVD7AhxT+L7/I= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-HXeQWiJPPqe8uQRVG5Nyxw-1; Fri, 03 May 2024 09:21:11 -0400 X-MC-Unique: HXeQWiJPPqe8uQRVG5Nyxw-1 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-6f452eb2035so135439b3a.0 for ; Fri, 03 May 2024 06:21:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714742470; x=1715347270; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kmo/rwZQd1lyus2Gkzo8TDtz4e4HkdDRoxbRfV4mTfg=; b=nnwvvzLILjo5gVG7wKHvuf+vqzGHOYi6uOOro6GzYJB/eePu4PULp4yT2njoFdlpTr QPsuKzolzlp7UTTZ6YunNFt1B4wJqKBQugXgcrPZWmQPBnEeJrjwESon4YdrFE8deAp6 kEZjjVZHhYf0eFva2TH5KCF+cb6/ee4Ypofp+dS5RFXHURfT/ytl67hxMvKhjgYc1cR5 8FtXptOueuw0WDsGYAYXIVmsMJRUmXUkyzyoBpAPRlhUx8auoSYoQI8sv5NFsty0JsoN vY68l3IF7SyqN9l8qdRx+5N5ts3cHDD2WZTnZnqKl87+P8tpo0mUSoVfK4MhorO3JK2K t74w== X-Forwarded-Encrypted: i=1; AJvYcCUMcJdq44FOSoPioJSyF6i3ckEE2V0JGxSU7bXI5fy6Znfc8sb2wQ9LgSzH0BRH0RycRt4tsP6JOtP3ok3C23I48JJv6hpgbooXbA== X-Gm-Message-State: AOJu0Yxf/UZM2DNJqhyQa2rVPlBm0GwQ/9zhHZArCJ6Zl2FOotSASzY0 dFFT4dqVsWVYCLwwGua3n2B/hYPy2zrThhCC8K4qeSJBJwXsO03NeBMhEX4TD6kcToGiaNX7wrK 5YXAzOeauzSSESIMYoaboE3DZ2y9jPCtvMUnQ+YPgAMa3DDZzbAqD/DOk44PGmCYq7n0= X-Received: by 2002:a05:6a00:22cc:b0:6f3:ea4b:d24d with SMTP id f12-20020a056a0022cc00b006f3ea4bd24dmr2792128pfj.9.1714742469783; Fri, 03 May 2024 06:21:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGopvcJCAsbf5XUh//RnU0yRDRXVrntLqfauVu4Ekzw/jX5JH7FPTtVsnBRKWmXXmaPy2WsOA== X-Received: by 2002:a05:6a00:22cc:b0:6f3:ea4b:d24d with SMTP id f12-20020a056a0022cc00b006f3ea4bd24dmr2792104pfj.9.1714742469376; Fri, 03 May 2024 06:21:09 -0700 (PDT) Received: from [150.1.200.12] ([71.212.146.31]) by smtp.gmail.com with ESMTPSA id n40-20020a056a000d6800b006f43e3de6f6sm2807004pfv.6.2024.05.03.06.21.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 May 2024 06:21:09 -0700 (PDT) Message-ID: <5f52efdb-68c6-4394-bba5-4bb251f1f2f2@redhat.com> Date: Fri, 3 May 2024 06:21:08 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdbserver: add client_state destructor To: Guinevere Larsen , gdb-patches@sourceware.org References: <20240503122906.3808986-1-blarsen@redhat.com> From: Keith Seitz In-Reply-To: <20240503122906.3808986-1-blarsen@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/3/24 05:29, Guinevere Larsen wrote: > --- > gdbserver/server.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/gdbserver/server.h b/gdbserver/server.h > index 0074818c6df..256294b0052 100644 > --- a/gdbserver/server.h > +++ b/gdbserver/server.h > @@ -133,6 +133,12 @@ struct client_state > own_buf ((char *) xmalloc (PBUFSIZ + 1)) > {} > > + ~client_state () > + { > + if (own_buf != nullptr) > + xfree (own_buf); > + } > + You don't need to guard xfree -- it deals gracefully with nullptr. Reviewed-by: Keith Seitz Keith > /* The thread set with an `Hc' packet. `Hc' is deprecated in favor of > `vCont'. Note the multi-process extensions made `vCont' a > requirement, so `Hc pPID.TID' is pretty much undefined. So