From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by sourceware.org (Postfix) with ESMTPS id 946433844044 for ; Fri, 10 Jul 2020 20:10:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 946433844044 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f66.google.com with SMTP id a6so9164939wmm.0 for ; Fri, 10 Jul 2020 13:10:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bYYgk3Bw16700eS6p/acnWeJSxNycQ6ujv7KoXVrrJ8=; b=uZqj3xNuq70ztJ82JCSshHYMhpKU08ajsZpnnppmdff+7nL15RpMrdOzQH5g8Q9gCH 3rey3K95QIUlQqdQbjoC2M9VpInKRdk4EiSls1h31Fx8oNp/fLpRhIhMwIXVEcbDyvnN a9p1hOhhBxXWy6gFV2Y9XlGduiJPhdCab/t8+D7n4WQE0WW60vTm3ZSPiUb+DiHMWkca D7BBs9NmkW7bfh8N2/3SmT5ZACm0HJFN/V04xX7FxE/EZzua96MGQrlXOTzcroTGXuaE KzQF7mSGphr+GufIiLtRLzgJXkwPU01PfbcMa5Jx6Fud5jg0EvO/MDwhP2g4sIv3/HCf w/eA== X-Gm-Message-State: AOAM532m1TOvVo/Mi3WN97oMIKzZSeVeVp+/ctDK5BoNBM4B7WyjT4p/ 7imktyBeeIUsog2UAf883I/G5xHlcGM= X-Google-Smtp-Source: ABdhPJzIagtb2wt1+gFOX1CSB0E4QnezUxCWCQDOSACVA4tNVnzckElV92eX1PkbQWAZS4XQhx/0BA== X-Received: by 2002:a7b:ce97:: with SMTP id q23mr6792548wmj.89.1594411821223; Fri, 10 Jul 2020 13:10:21 -0700 (PDT) Received: from ?IPv6:2001:8a0:f91a:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f91a:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id w12sm12489464wrm.79.2020.07.10.13.10.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2020 13:10:19 -0700 (PDT) Subject: Re: [PATCH v4 12/14] Add new command "maint print core-file-backed-mappings" From: Pedro Alves To: Kevin Buettner , gdb-patches@sourceware.org References: <20200705225807.2264705-1-kevinb@redhat.com> <20200705225807.2264705-13-kevinb@redhat.com> <24e598f3-2de5-f34c-c4ab-47a1cda89ec9@palves.net> Message-ID: <5f5d252a-6dd5-2516-5433-610aa01bedfe@palves.net> Date: Fri, 10 Jul 2020 21:10:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <24e598f3-2de5-f34c-c4ab-47a1cda89ec9@palves.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2020 20:10:24 -0000 On 7/10/20 9:08 PM, Pedro Alves wrote:> >> +static void >> +maintenance_print_core_file_backed_mappings (const char *args, int from_tty) >> +{ >> + core_target *targ = get_current_core_target (); >> + gdb_assert (targ != nullptr); > This assert will crash GDB if you're debugging a core dump, right? > That doesn't look right. (Please add a test for that.) This assert will crash GDB if you're NOT debugging a core dump, of course.