From: Magne Hov <mhov@undo.io>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb/source.c: Fix undefined behaviour dereferencing empty string
Date: Thu, 22 Sep 2022 14:11:20 +0100 [thread overview]
Message-ID: <5s35cjlfk7.fsf@undo.io> (raw)
In-Reply-To: <e961a6f1-240d-c106-86a8-fab7fffd6f75@simark.ca>
On Wed, Sep 21 2022, Simon Marchi wrote:
>> result = openp (path, OPF_SEARCH_IN_PATH | OPF_RETURN_REALPATH,
>> cdir_filename.c_str (), OPEN_MODE, fullname);
>
> Thanks, this is OK, nice cleanup.
Thanks, I'll push the patch tomorrow morning if no other concerns are raised.
>
> Simon
--
Magne Hov | Software Engineer | Direct: +44 7395 395 648 | mhov@undo.io
Undo | Record. Replay. Resolve
next prev parent reply other threads:[~2022-09-22 13:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 18:31 [PATCH] " Magne Hov
2022-09-20 19:07 ` Tom Tromey
2022-09-21 14:51 ` Magne Hov
2022-09-21 14:58 ` [PATCH v2] " Magne Hov
2022-09-21 15:52 ` Simon Marchi
2022-09-22 13:11 ` Magne Hov [this message]
2022-09-24 8:58 ` Magne Hov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5s35cjlfk7.fsf@undo.io \
--to=mhov@undo.io \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).