From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 224AB3858422 for ; Thu, 22 Sep 2022 13:11:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 224AB3858422 Received: by mail-wr1-x42c.google.com with SMTP id c11so15431805wrp.11 for ; Thu, 22 Sep 2022 06:11:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=Zf9Bq/h4yLxUCpOTDqulOgEV9/JUR2hCl4DjIIti7Nc=; b=2BSJxMj/mMlCkX8mJs7rx6bKY44MF2MMNfwhoIzsMMhS7BsCFr1+iDlk9JZp0Ho9UJ uJIhoiGZ/yawdv6sWqTdJ84u6aH2M7M/F6LKRprpeyrVzNR9zgYwfGa0lmYcUAcnAjk1 sS+TS4JjG8XK50EsoyOPb0iAgy9VwQBEcxdLDT/vlMVFJx3Qw5h4FVo3qmbbQ2JnQAqF M8mAYsp86focPv2JBKRc8d4lRnziW08rdxFcCot4KKUZbsygxdmNbp3+pvih9cLWIzrQ Xbx/zso6oUIjZoGN8nOPcwDDFdwlXHwOVPRbGrBDggYFyLWPLt7GGKVufxv2XP3kr6Ic kU8g== X-Gm-Message-State: ACrzQf0MUunrVqbP/S1d6faYpUqp+0nKrg9ksXAb9wJxp4ODt8del2oT LhsK26C5KTiYgGLYmOAcXhDe/6L8qjqRjhueaukyTTfYe9In4Vr2dhw1WMgpd/XtYUBHPTFSzXd +4bROGdn7vUZM5jdr4MlXk20Os6J77VoNwZjrtmexa5sy0fxN5xBRFtiSh4+l9p/diA== X-Google-Smtp-Source: AMsMyM5Vj0RPCS3GgjIsMagCvLAbijGSH0y4AZUPm59uQ/5ThXHeqpyo3yU7bnh7HVOEygVrXz1y4Q== X-Received: by 2002:adf:fa12:0:b0:228:62a8:7c79 with SMTP id m18-20020adffa12000000b0022862a87c79mr1982957wrr.231.1663852282877; Thu, 22 Sep 2022 06:11:22 -0700 (PDT) Received: from sbrinz-thinkpad (185.205.174.218.default.telcom.network. [185.205.174.218]) by smtp.gmail.com with ESMTPSA id q63-20020a1c4342000000b003b4bd18a23bsm5819077wma.12.2022.09.22.06.11.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Sep 2022 06:11:22 -0700 (PDT) From: Magne Hov To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb/source.c: Fix undefined behaviour dereferencing empty string In-Reply-To: References: <20220915183141.3484234-1-mhov@undo.io> <20220921145834.837969-1-mhov@undo.io> Date: Thu, 22 Sep 2022 14:11:20 +0100 Message-ID: <5s35cjlfk7.fsf@undo.io> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2022 13:12:21 -0000 On Wed, Sep 21 2022, Simon Marchi wrote: >> result = openp (path, OPF_SEARCH_IN_PATH | OPF_RETURN_REALPATH, >> cdir_filename.c_str (), OPEN_MODE, fullname); > > Thanks, this is OK, nice cleanup. Thanks, I'll push the patch tomorrow morning if no other concerns are raised. > > Simon -- Magne Hov | Software Engineer | Direct: +44 7395 395 648 | mhov@undo.io Undo | Record. Replay. Resolve