public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Magne Hov <mhov@undo.io>
To: Tom Tromey <tom@tromey.com>,
	Magne Hov via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb/source.c: Fix undefined behaviour dereferencing empty string
Date: Wed, 21 Sep 2022 15:51:19 +0100	[thread overview]
Message-ID: <5sczbolr14.fsf@undo.io> (raw)
In-Reply-To: <87mtat6f0h.fsf@tromey.com>

On Tue, Sep 20 2022, Tom Tromey wrote:

> I wonder if this code should be changed to use path_join instead.
> That function doesn't seem to have this bug:

Good point, I've rerun the test suite and I will send an updated patch.

-- 
Magne Hov | Software Engineer | Direct: +44 7395 395 648 | mhov@undo.io

Undo | Record. Replay. Resolve

  reply	other threads:[~2022-09-21 14:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 18:31 Magne Hov
2022-09-20 19:07 ` Tom Tromey
2022-09-21 14:51   ` Magne Hov [this message]
2022-09-21 14:58 ` [PATCH v2] " Magne Hov
2022-09-21 15:52   ` Simon Marchi
2022-09-22 13:11     ` Magne Hov
2022-09-24  8:58   ` Magne Hov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5sczbolr14.fsf@undo.io \
    --to=mhov@undo.io \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).