From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id E8530385840A for ; Wed, 21 Sep 2022 14:51:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E8530385840A Received: by mail-wr1-x430.google.com with SMTP id y5so10336189wrh.3 for ; Wed, 21 Sep 2022 07:51:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=kcFC1V99ZHhEVS7aSg0j2dN8MvfLNmk34EOHYklbO+w=; b=0MFGFeWsQ8nQ8tP5R5wd2WtTz0s951HXNOGtolh7umo7yqSChDMCF6eY2kz0jnU8Jj D2kAd05TUX+a9awdmyeuny0uvKov5Hyq0PH850M83j51Pwh7jZv1XTa7lTPafs54xTwx 4OOj3AdQVkYEx1g8zgzJ4GpKcKUHeftgMdMW7iJ6Dl2Mabl3E04DHkm8SEjUxvyHW+EF h7gSMyo1460Fe5TNuH4PQ9e/jDbldSGTAyBq/GInhF6SAFzKCaCqciqXY4M2oD4GfMVb seK3QAM3VRoEIWqoReYPAH2XSMQAxrnFa6MtpRh/AOdvfuVyJUKYZK9h0GnoA/xgI8HS YvOA== X-Gm-Message-State: ACrzQf3z5t/kEgdA4vmF5Jq1wOCc9eslTd3RD8+cQsK9d1AiY5QRvhMZ yrEpe0F/63n6HVKIgKHJdsFWxiBTZSVzyjk34WeuNq+v5QbzVDmVMmAsfm0sqSgcZwRJFA1Y8EC EgOPP3ZC546ylYZaUZw0LO7gkTTrMoTZPWodZRxwn+cdaDl4JrFyxoAcznqYYRLVtjA== X-Google-Smtp-Source: AMsMyM596CDC3Zw424olUyS60Qij4aZMBC3WgQ9H6X7dCC01WD/uXkQ1TqCxt+YE25KO3j2ERSp00w== X-Received: by 2002:a05:6000:1a8d:b0:22a:44e9:831e with SMTP id f13-20020a0560001a8d00b0022a44e9831emr18135368wry.575.1663771881708; Wed, 21 Sep 2022 07:51:21 -0700 (PDT) Received: from sbrinz-thinkpad (nrwh-14-b2-v4wan-164652-cust345.vm23.cable.virginm.net. [81.96.125.90]) by smtp.gmail.com with ESMTPSA id n12-20020a05600c294c00b003b47ff307e1sm2933874wmd.31.2022.09.21.07.51.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 07:51:20 -0700 (PDT) From: Magne Hov To: Tom Tromey , Magne Hov via Gdb-patches Subject: Re: [PATCH] gdb/source.c: Fix undefined behaviour dereferencing empty string In-Reply-To: <87mtat6f0h.fsf@tromey.com> References: <20220915183141.3484234-1-mhov@undo.io> <87mtat6f0h.fsf@tromey.com> Date: Wed, 21 Sep 2022 15:51:19 +0100 Message-ID: <5sczbolr14.fsf@undo.io> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2022 14:51:25 -0000 On Tue, Sep 20 2022, Tom Tromey wrote: > I wonder if this code should be changed to use path_join instead. > That function doesn't seem to have this bug: Good point, I've rerun the test suite and I will send an updated patch. -- Magne Hov | Software Engineer | Direct: +44 7395 395 648 | mhov@undo.io Undo | Record. Replay. Resolve