RE: [PATCH v2] gdb: fix eval.c assert during inferior exit event

[Magne Hov <mhov@undo.io>]

Thanks for these comments, I'll make sure to address them in a revised
patch. 

On 11 May 2021 07:16, "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com> wrote:

> On Monday, May 10, 2021 7:21 PM, Magne Hov wrote:
>> diff --git a/gdb/eval.c b/gdb/eval.c
>> index 1b3c974009a..34c6c6160d4 100644
>> --- a/gdb/eval.c
>> +++ b/gdb/eval.c
>> @@ -93,7 +93,7 @@ struct value *
>>  expression::evaluate (struct type *expect_type, enum noside noside)
>>  {
>>    gdb::optional<enable_thread_stack_temporaries> stack_temporaries;
>> -  if (target_has_execution ()
>> +  if (target_has_execution ()  && inferior_ptid != null_ptid
>
> Nit: there is an extra space before `&&`.
>
>>        && language_defn->la_language == language_cplus
>>        && !thread_stack_temporaries_enabled_p (inferior_thread ()))
>>      stack_temporaries.emplace (inferior_thread ());
>> diff --git a/gdb/testsuite/gdb.python/py-events.exp b/gdb/testsuite/gdb.python/py-events.exp
>> index e89cd8b021b..9aa0680fd0e 100644
>> --- a/gdb/testsuite/gdb.python/py-events.exp
>> +++ b/gdb/testsuite/gdb.python/py-events.exp
>> @@ -197,18 +197,33 @@ gdb_test_multiple "continue" $test {
>>  gdb_test_no_output "delete $second_breakpoint"
>> 
>>  #test exited event.
>> +proc get_process_id {test} {
>> +    global gdb_prompt
>> +    gdb_test_multiple "info proc" $test {
>> +	-re "process (\\d+).*$gdb_prompt $" {
>> +	    set process_id $expect_out(1,string)
>> +	    pass $test
>
> Using `$gdb_test_name` is preferable here, I believe.
>
> -Baris
>
>
>
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928